-
Notifications
You must be signed in to change notification settings - Fork 25
feat: Add color mode toggle with system preference support #133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for hoppdocs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
@konsalex |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @naveenkumar29052006 thanks for the PR. Before reviewing locally could you please do some cleanup as there are unrelated changes to the root package and port configuration.
Also sign the CLA please. Thanks
- POSTGRES_DB=hopp | ||
ports: | ||
- '5432:5432' | ||
- '5433:5432' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR should not change dev setup
backend/env-files/.env.local
Outdated
SESSION_SECRET=renkey-hash-key | ||
REDIS_URI=redis://localhost:6379/0?protocol=3 | ||
DATABASE_DSN=postgres://hopp:password@localhost:5432/hopp?sslmode=disable | ||
DATABASE_DSN=postgres://hopp:password@localhost:5433/hopp?sslmode=disable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The same as above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will review shortly @naveenkumar29052006 .
Builds are failing with:
the six-letter p-prefixed code.
9:11:43 PM: ➤ YN0086: │ Some peer dependencies are incorrectly met by dependencies; run yarn explain peer-requirements for details.
9:11:43 PM: ➤ YN0028: │ The lockfile would have been modified by this install, which is explicitly forbidden.
9:11:43 PM: ➤ YN0000: └ Completed
9:11:43 PM: ➤ YN0000: · Failed with errors in 0s 251ms
9:11:43 PM: Error during Yarn install
9:11:43 PM: Failing build: Failed to install dependencies
I see this is because root yarn.lock was modified with irrelevant packages, can you also clean it?
sir could you please check now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After the cleanup update the root yarn.lock
You were right sir i mistakenly changed dependencies of docs and tauri and i had ran yarn also so could u please check now |
Added a color mode toggle button in the sidebar, placed to the left of the Logout button.
Supports light and dark themes based on system preference.
Persist user’s preference in localStorage.
Handles adding/removing dark/light CSS classes dynamically.
Provides a Context and Provider for managing theme state across the app.
