feat: rooms out of beta #118
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for hoppdocs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
iparaskev
requested changes
Oct 7, 2025
| type Room struct { | ||
| ID string `json:"id" gorm:"unique;not null"` // Standard field for the primary key | ||
| Name string `gorm:"not null" json:"name" validate:"required"` | ||
| UserID string `gorm:"not null" json:"user_id" validate:"required"` |
There was a problem hiding this comment.
It seems that we don't use this anywhere. We are only using the TeamID for creating/deleting/gettings/modifying.
| return c.NoContent(http.StatusNoContent) | ||
| } | ||
|
|
||
| func (h *AuthHandler) GetRoom(c echo.Context) error { |
There was a problem hiding this comment.
Nit: Should this be named EnterRoom?
| OVERLAY_WINDOW_INITIAL_SIZE, | ||
| )) | ||
| .with_content_protected(true) | ||
| .with_content_protected(false) |
| reset: () => void; | ||
| setCalling: (calling: string | null) => void; | ||
| setCallTokens: (tokens: CallState | null) => void; | ||
| // setRoom: (room: components["schemas"]["Room"] | null) => void; |
| teammates: null, | ||
| calling: null, | ||
| callTokens: null, | ||
| // room: null, |
Comment on lines
+131
to
+134
| // setRoom: (room) => | ||
| // set((state) => { | ||
| // state.room = room; | ||
| // }), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #21
Co-developed with @mumair5393