Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user to config #913

Merged
merged 1 commit into from
Jul 11, 2016
Merged

Add user to config #913

merged 1 commit into from
Jul 11, 2016

Conversation

Vivalldi
Copy link
Collaborator

@Vivalldi Vivalldi commented Jun 21, 2016

I have a feeling that this is too "simple" in that no user specific config is merged with other configs but i stayed away from doing that so that plugin developers can choose whether to use user based config (for example the login plugin redirect) or if the want to use overarching config.

@flaviocopes
Copy link
Contributor

Can you describe the end goal, what will this change allow to do?

@Vivalldi
Copy link
Collaborator Author

This will allow user specific config to be retrieved with config->get('user.field.subfield);` in the same way that plugin, theme, and site config is grabbed.

That being said it is still possible in plugins to retrieve user config by using $grav['user']['field']['subfield'];

@flaviocopes
Copy link
Contributor

I think it can be useful, letting @rhukster the final word :)

@rhukster rhukster merged commit 8e7cc01 into getgrav:develop Jul 11, 2016
@rhukster
Copy link
Member

is this reliable between pages?

@Vivalldi
Copy link
Collaborator Author

Between pages? As in, if I log in and then navigate to another page, and then another?

@rhukster
Copy link
Member

Exactly... i merged it then thought about this as there is not going to be any persistence to the compiled configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants