Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the addFrame method to ImageMedium #3323

Merged
merged 2 commits into from
Jun 1, 2021

Conversation

phmg701
Copy link
Contributor

@phmg701 phmg701 commented Apr 20, 2021

This is my first-ever fork, edit and PR on GitHub, I sincerely hope I did it right!
Thanks!

Add needed magic actions to enable image frame creation.
Adds addFrame method that can be (recursively) called from Twig.
@mahagr mahagr requested a review from rhukster April 22, 2021 07:56
@phmg701 phmg701 marked this pull request as draft May 9, 2021 07:23
@phmg701 phmg701 marked this pull request as ready for review May 9, 2021 07:23
@phmg701
Copy link
Contributor Author

phmg701 commented May 26, 2021

Hello @mahagr
Being my first PR, have I missed something? Can this be merged?
Thanks!

@mahagr
Copy link
Member

mahagr commented May 26, 2021

It's up to @rhukster to decide if this behavior belongs to core Grav.

@rhukster rhukster merged commit 18d7fd4 into getgrav:develop Jun 1, 2021
@rhukster
Copy link
Member

rhukster commented Jun 1, 2021

not sure it's that useful as CSS is way more flexible to create a border on an image, but whatever, doesn't do any harm to have it I guess.

@phmg701 phmg701 deleted the ImageMedium-addFrame branch June 2, 2021 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants