Pages search is performed only by folder name

[Karmalakas]

Am I assuming correctly, that pages search in Admin should be on these four fields?

I've tried it seems everything (even editing the system ... pages.yaml and completely emptying cache directory and then saving a page), but it searches only by name (it's folder I guess). Wanted to help here on Discourse, but it seems there's a bug.

Other custom flex-objects I have work perfectly fine with fields defined in this config path.

Did some debugging and here's what I found:

1. Children pages return null properties
   $property here is title, but $this PageObject does not contain it and returns null and therefore page does not match the search phrase tipo
   

2. Even though I definitely have such page. This Tipo page is a typography folder page
   

3. Here's a full view when PageObject::getNestedProperty() returns null
   

   1. ArrayProperty doesn't check in header
      
   2. And ObjectProperty checks defined properties, which doesn't look like a place to be searched
      

Beyond that point I can only guess how it's supposed to be, hence the issue :)

[masetto]

Hi @mahagr, are you sure that issue is fixed? Because if I search by title I have not expected results.

[mahagr]

It works for me, just searched for a title.

[masetto]

Are you sure that the title is different from folder name?

[Karmalakas]

I completely forgot to test this. Will try probably after work

[mahagr]

Yeah, they had no common letters in them.

[Karmalakas]

For me now it searches by Page Title and Menu Title, but does not by folder name nor by slug. Is it supposed to be like this? What are key and name fields? My guess key would be a folder, but not sure. Still, according to default config, it should search these four fields - key, name, menu and title, shouldn't it?

[masetto]

Hi, sorry, but for me it does not work and I don't understand why... This is my page frontmatter:

title: 'Senza titolo'
taxonomy:
    category:
        - Rinascita
    tag:
        - artwork
        - winner
        - biennale
template: artwork
firstname: Li
lastname: Yichen

The folder name is li-yichen. I'm using Grav v1.7.17 - Admin v1.10.17 on Linux.
In admin pages, if I search titolo I have no results.

[Karmalakas]

By any chance you have a multi-language site and search in a wrong language, @masetto? Just guessing

[mahagr]

I removed name (template has it's own filter) and added slug to search fields.

Can you try (see the commit) if it now behaves how you expect it to?

[Karmalakas]

I removed name (template has it's own filter) and added slug to search fields.

Can you try (see the commit) if it now behaves how you expect it to?

Now it searches exceptionally only by folder. Neither Menu/Page title nor slug works.
Not sure what happened, but even after I restored to initial 4 fields it doesn't work anymore

[mahagr]

@Karmalakas I cannot reproduce your issue. The search uses both title and slug, I tested that by using a different language.

[Karmalakas]

I tried on two languages 😕 Will try again later on fresh install 🤔

[mahagr]

So maybe this issue is multilanguage-related...

[mahagr]

I can confirm that the issue is present with multilanguage, when you select another language than the default one.

[Karmalakas]

I tried both default and not 🤔
I see you added the label Fixed, but is it really? Or there should be another issue created for multi-language pages search?

(I'll still try on fresh install)

[mahagr]

No, I removed the fixed tag :)

Actually there were two issues:

• the slug was not in the search field list
• when using multi-language, search is performed before looking at the translated items

The first one has been fixed, but the second one has not.

[Karmalakas]

No, I removed the fixed tag :)

My bad 🤦‍♂️

---

Thanks for the clarification :)

[masetto]

Hi,
sorry, but the search still doesn't work for slug and title with multiple languages, not even for the default language.
For me this is a vital function because I have sites with hundreds of pages.

[phmg701]

Hello, I can confirm search is only performed by original folder name. No slug search, no tile search.
It would be great to have wider search options at least for the selected language.
Latest release Grav + Plugins as of today.
Thank you!

[mahagr]

Should now be fixed. Search and filtering in general now matches the displayed items (or current language). The fix will be released early next week.

[phmg701]

Confirmed working by searching both slug or title in 2nd language and not returning result for the main language (English) as expected. Fresh local 1.7.31 install just updated to 1.7.32. Thanks!

[Karmalakas]

Finally got to it 🙂 Sorry for the delay and keeping issue open.
Just tested and it seems to be working as expected. Thank you 🙂