Directory cache is not invalidated after saving page

[Flamenco]

This code does not work.

$page->save();
Cache::clearCache('invalidate');
$grav->redirect('/admin/pages' . $newPage->rawRoute());

The redirect page shows the following message, although the page is saved and served:

"This page will not exist until it is saved."

After several seconds and a page refresh, the error goes away. It also goes away by clearing the cache in the admin.

This code works after calling $directory->clearCache();

$page->save();
Cache::clearCache('invalidate');
$flex = $grav['flex'];
$directory = $flex->getDirectory('pages');
$directory->clearCache();
$grav->redirect('/admin/pages' . $newPage->rawRoute());

I would like to simply call the following and be isolated from the implementation.

$page->save([invalidate=>true]);

[Flamenco]

After downloading Grav v1.7.0-rc.18 - Admin v1.10.0-rc.18, I tried the following code:

$page->save();
$grav->redirect('/admin/pages' . $newPage->rawRoute());

Same error.

After waiting 10 seconds, and refreshing, the error goes away and the edit page shows up.

[Flamenco]

Here are a couple of utility functions I added to core-service-manager as our workaround.

	/**
	 * Call this function, after saving a page, if needing to redirect back to the page's admin.
	 */
	public function updateAdminCache(): void
	{
		if ($this->gravVersionMatches('1.7.0-rc.0', '>=')) {
			Cache::clearCache('invalidate');
			$flex = $this->grav['flex'];
			$directory = $flex->getDirectory('pages');
			$directory->clearCache();
		}
	}

	/**
	 * A workaround that saves a page and then updates relevant Admin plugin caches.
	 * @param Page $page
	 */
	public function save(Page $page)
	{
		$page->save();
		$this->updateAdminCache();
	}

Invoke it like this:

$this->grav['core-service-util']->save($myPage);

I am currently adding methods to CSM to help write code blocks to run under different versions of Grav, GravAdmin, and PHP, so this will be updated to call the proper code depending on the installation.

[mahagr]

BTW, you cannot have Page as the type hint (in save), it will not work with flex pages, just with the old class.

You should be using PageInterface instead. Is your class using the old Page class?

[Flamenco]

Yes this is legacy code and I am not currently using PageInterface.

[mahagr]

I took a quick look; saving the old Page object doesn't affect admin because of it's using the new Flex Page.

I think we need to add some code to signal the another party that there has been a change.

[mahagr]

@Flamenco Should be fixed now, the old code should work.