Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown function wrongly expects at least 2 parameters. Easy fix! #2635

Closed
eulores opened this issue Aug 18, 2019 · 3 comments
Closed

Markdown function wrongly expects at least 2 parameters. Easy fix! #2635

eulores opened this issue Aug 18, 2019 · 3 comments
Assignees

Comments

@eulores
Copy link

eulores commented Aug 18, 2019

I believe the parameters in the function header have to be switched around.

Wrong:

public function markdownFunction($context = false, $string, $block = true)

Better:

public function markdownFunction($string, $block = true, $context = false)

Simple testcase

This twig code fragment throws an error:

{% markdown *}
**bold?**
{% endmarkdown %}

public function markdownFunction($context = false, $string, $block = true)

@mahagr
Copy link
Member

mahagr commented Aug 19, 2019

That is not markdown function but a twig tag issue.

@mahagr
Copy link
Member

mahagr commented Aug 19, 2019

Issue was introduced 10.8.2019 in revision 618a599.

@rhukster
Copy link
Member

Fixed in latest release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants