-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect routing on duplicate slashes #2184
Comments
The word "incorrectly" implies that there's a "correct" way to interpret those slashes. But if you look at the relevant RFCs, I can find no prescribed normalization of such slashes. Did I miss something? So URI paths containing such are simply invalid, and the result of running such a URL through various tools is undefined. |
URL starting with That said the behaviour you observed in the learn site is wrong, it should end up to 404 page. |
Confirmed this to be a bug in |
…etgrav#2184]" Previous change broke running Grav under Load Balancer with custom_base_url set. Also, it's not a good idea to add 3rd party domain into host value, which could be accidently reused some time in the future. This (not counting CHANGELOG) reverts commit 0af3385.
URL pathnames prefixed by duplicate slashes ('//', '///', ...) are incorrectly interpreted as absolute URLs. At present, the URL https://learn.getgrav.org//__FAKE_HOSTNAME__/content/routing
is resolved to
https://learn.getgrav.org/content/routing
This is caused by the
$bits = parse_url($uri);
asignment in Uri.php.The text was updated successfully, but these errors were encountered: