#22 : header_var with 'defined', not 'default'

[hugobqd]

The default state doesn't work with default when empty, use twig's defined instead

[cweiske]

My issue was more that the "show_sidebar" setting is used to determine if the pagination should be shown.

[hugobqd]

OK, I see, I have modified the wrong variables assignments. Does the 'default' work fine for you?

[cweiske]

sorry, can't test right now.

[tribut]

Yes, both the logic (using show_sidebar for unrelated settings) and using default are broken. The changes in this PR make sense imho.

However, I suggest using the value from /blog for all the settings (and allow them to be overridden) like so:

{% set show_breadcrumbs = header_var('show_breadcrumbs')|defined(header_var('show_breadcrumbs', '/blog'))|defined(true) %}
{% set show_sidebar = header_var('show_sidebar')|defined(header_var('show_sidebar', '/blog'))|defined(true) %}
{% set show_pagination = header_var('show_pagination')|defined(header_var('show_pagination', '/blog'))|defined(true) %}

[tribut]

The settings where also inconsistently applied when comparing blog and item pages. I've fixed all of this in #37, which obsoletes this PR.