Skip to content

Added classes for fields, which are missing in some field types #2438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
pmoreno-rodriguez wants to merge 75 commits into
base: develop
Choose a base branch
from
Open

Added classes for fields, which are missing in some field types #2438

pmoreno-rodriguez wants to merge 75 commits into from

Conversation

@pmoreno-rodriguez
Copy link
Contributor

@pmoreno-rodriguez pmoreno-rodriguez commented Jan 7, 2025

No description provided.

@pmoreno-rodriguez
Copy link
Contributor Author

pmoreno-rodriguez commented Jan 7, 2025

classes is a common attribute for fields, according to Grav Documentation.
The fields of this PR have not the classes attribute.

@pmoreno-rodriguez
Copy link
Contributor Author

pmoreno-rodriguez commented Mar 22, 2025

Hi @rhukster . Any advance about this PR?

@rhukster
Merge tag '1.10.49.1' into develop
0c593f5 
Release v1.10.49.1

# -----BEGIN PGP SIGNATURE-----
#
# iQIzBAABCAAdFiEEwbiolRD/eEYBHGp5nyzziuvbCuAFAmi44PAACgkQnyzziuvb
# CuD1HA/+OGUPdLrU46H9e4XXxKF+TAN/1xggdHhHoCef58YNTNPLYS40x3d0JGb2
# LPg3g0Iy/0AJboeXUdWKtdDSPGWg6x2dVddsDo4v/OYchLftHy6HOkSFhmw0bpQD
# iz7vBcX2zfd7VxhoGt5p8NDYFCZ7hGjXbqVg1Xyd7sqTGT6nRMl52SK5mbTul5AM
# EzTepF7Cl95y/3bWdySqiRY+955gCWI+j2mZwwL0rN2/R9eu8+z2JZWilkloDOn8
# d6A12rTvfJvsu5ZtrgtEJVNJzcwSCbvuA/k43t0YE532UJPlpIkIUrbwTYUiAEZL
# PFu9OwmNLZ7FYyRejJZHoGIF/9cJMc43p5PMuPVbx2ppcc65Ugr9SmnqkkJ4pvOq
# OIaoB/ZK1OC7GJkCZ6GfEWFnT4XsqB7d0xCmk5ch9c71jn7mDR/88fk3DzMA0/OI
# uFKgFevxw1At7sZMhyhc+F19z/XYCk+s9WkJT9AQMD2zBfGNGwaSiGnr2gdOHGEC
# G3yeFs8ixwnfVSnSfEVtdzYhM7+Ah9MNnpqdGTyY1ny7zfdBy8su6cB0a78WYYxj
# izIm6tjLm42moTMdrOB4OcTqk89zDEiePsf/hHAUt7/CaHWpXPZeavWiTnqspUF9
# rVRKSHaAYU8PmMc7wRXn3a8R2chGb6X+P8oW8DMVmbsa+5vwrxk=
# =NjBq
# -----END PGP SIGNATURE-----
# gpg: Signature made Wed Sep  3 18:44:32 2025 MDT
# gpg:                using RSA key C1B8A89510FF7846011C6A799F2CF38AEBDB0AE0
# gpg: Good signature from "Andy Miller <rhuk@mac.com>" [ultimate]
@rhukster
improved login/session handling
325764a 
Signed-off-by: Andy Miller <rhuk@mac.com>
@rhukster
upgrade JS
6d673fc 
Signed-off-by: Andy Miller <rhuk@mac.com>
@rhukster
looks like a fix for deeply nested sortable fields!
a8ac6f8 
Signed-off-by: Andy Miller <rhuk@mac.com>
@rhukster
minor css fixes
0334dfa 
Signed-off-by: Andy Miller <rhuk@mac.com>
@rhukster
safe upgrade progress
a4e0c83 
Signed-off-by: Andy Miller <rhuk@mac.com>
@rhukster
more updates
6ff2c45 
Signed-off-by: Andy Miller <rhuk@mac.com>
@rhukster
upgrade flow
4d789fc
@rhukster
more upgrade flow fixes
f642992
@rhukster
yet more upgrade flow fixes
e33e99e
@rhukster
yet more upgrade flow fixes 2
532274b
@rhukster
yet more upgrade flow fixes 3
b23940f
@rhukster
new and improve admin async upgrade process
f08a32c
@rhukster
improvements to logging and command calling
79c061a
@rhukster
progress status during upates
679a237
@rhukster
ensure binaries are executable
8142b48
@rhukster
Merge branch 'develop' of github.com:getgrav/grav-plugin-admin into d…
a21e5ec 
…evelop
@rhukster
fix for progress bar
06461be
@rhukster
more progress fixes
099e6cd
@rhukster
missing package size
f15d3a3
@rhukster
fix stuck progress at 80%
ca65770
@rhukster
fix stuck progress at 80% - part deux
4a2b386
@rhukster
dedicated endpoint for upgrade
51551b3
@rhukster
dedicated endpoint for upgrade
746f09d
@rhukster
Merge branch 'develop' of github.com:getgrav/grav-plugin-admin into d…
84d6cca 
…evelop
@rhukster
use new safeupgrade route
78fc74a
rhukster and others added 28 commits October 18, 2025 12:27
@rhukster
minor tweaks
d437bd1
@rhukster
Revert "minor tweaks"
64bbed1 
This reverts commit d437bd1.
@rhukster
bg process for restore
84cf62b
@rhukster
fixes for restore
1e14c47
@rhukster
fixes for progress bar
0663272
@rhukster
fixes for polling restore
c4fb1f7
@rhukster
create adhoc snapshot
419fcc3
@rhukster
fix labels in snapshots
e81ed34
@rhukster
minor tweaks
08862b5
@rhukster
ignore unpublished plugins
ce38f72
@rhukster
timer tweaks
49a9b3b 
Signed-off-by: Andy Miller <rhuk@mac.com>
@rhukster
stop deleting recover.window file
00be4fa 
Signed-off-by: Andy Miller <rhuk@mac.com>
@rhukster
fix for deprecation notice
9078633 
Signed-off-by: Andy Miller <rhuk@mac.com>
@rhukster
algnment of array field fix
0a1d38a 
Signed-off-by: Andy Miller <rhuk@mac.com>
@rhukster
simplified safe-upgrade
b568929 
Signed-off-by: Andy Miller <rhuk@mac.com>
@rhukster
admin fixes for safe update
1dca097 
Signed-off-by: Andy Miller <rhuk@mac.com>
@rhukster
fix status bar percent
1cf9aa1 
Signed-off-by: Andy Miller <rhuk@mac.com>
@rhukster
improved safe upgrade success message
a65eeed 
Signed-off-by: Andy Miller <rhuk@mac.com>
@rhukster
some fixes for new safe-upgrade
dfc1875 
Signed-off-by: Andy Miller <rhuk@mac.com>
@rhukster
regression fix for session/logout
0a7f9c0 
Signed-off-by: Andy Miller <rhuk@mac.com>
@rhukster
prepare for release
c4659c2 
Signed-off-by: Andy Miller <rhuk@mac.com>
@rhukster
Merge branch 'release/1.10.50'
c2560d4
@rhukster
Merge tag '1.10.50' into develop
419ab56 
Release v1.10.50

# -----BEGIN PGP SIGNATURE-----
#
# iQIzBAABCAAdFiEEwbiolRD/eEYBHGp5nyzziuvbCuAFAmkXTbEACgkQnyzziuvb
# CuDW5BAArQLCnU/02r4r73WQ50FfojJOnH8+i0K2zTVVtheNvUsbOEbYTokCPrrQ
# 5udhL1Psd004g3M0uiKYAv10D3GmRuBi+q8LZaI+AMDRY1dDURjDSzKL70FTqgUa
# TEQX5snT0tuPRUzS27hJi3l7P27WNQwK29Pl0m+JDAUcqzoqFZZzJoawQRBRnfeH
# AnmhocPNOYIV23RsQzE5XzO0Y0SAz8DbFLoUVyVMP+Cr2YuP7wqd0cSjkqFh+FS4
# eLGjPj7OA+oBHDoiaITlAMXCAH7mpmCnxPqjOKLdR9S6C7/btAWa1p+j3nLLv1od
# h2nM/e5K+pxg7eb3BHK0Xs2j5YNl7RfgKspg3BeSVueOTCniaPC8lzexp0MlIaKn
# Aulc7g7egb75LEknDpgt7vM636Vbv/noxMeqgwyxMnhJ60iojq6Hsxtk9u/699kL
# /1s+a4VjkGPgxQHqErNu4ig9gFPA1nHNwwW2ngXU+5F44lKD+025bgMPqjEutGaR
# waYEp6t8hp6IUJM3CI8NidxPlnU82kSHUAhem16k9cDxhsau8DsST91enqdREt4G
# xdqxyBLOQDLlPhtlMNfdh1ojrbUQx+UUdVcMnmPWpO4y+BHRqRmFIhb0W+wPdxCt
# PwIt/55ICTR57HzVXvAX4k0nkFCj4Go5x0Gj6sPbGCOql/zyTwg=
# =elGV
# -----END PGP SIGNATURE-----
# gpg: Signature made Fri Nov 14 15:41:37 2025 GMT
# gpg:                using RSA key C1B8A89510FF7846011C6A799F2CF38AEBDB0AE0
# gpg: Good signature from "Andy Miller <rhuk@mac.com>" [ultimate]
@rhukster
honor safe_upgrade setting
bbed7e5 
Signed-off-by: Andy Miller <rhuk@mac.com>
@rhukster
more safe-guards
7d7d30e 
Signed-off-by: Andy Miller <rhuk@mac.com>
@rhukster
Merge branch 'release/1.10.50'
1ec8fab
@rhukster
Merge tag '1.10.50' into develop
1e498e2 
Release v1.10.50

# -----BEGIN PGP SIGNATURE-----
#
# iQIzBAABCAAdFiEEwbiolRD/eEYBHGp5nyzziuvbCuAFAmkXWj0ACgkQnyzziuvb
# CuCj6g/+PhImP1yC2fye42BZ5m4gXNwZH9bhW7K/xh7AZTMePk1p8E/dLemFLXJk
# GSdatr2DGC7s5VnPzSimVCi9u8a8Ov/wqOGl1f5gMQTrI7+G+kWvPXT7z1Ye0T+i
# Z8+KgzZYQ3VJP6jnSyVT1PWckPdzmK2S0dVeeh4CnZSdzwAV8qQ/JdjO7vHueQ5H
# JFT0kRYEMyc0xOknEyzZVP2jR6yXZMAHgebmuxsbrMegQSBLPFUk6G94nNn/5HZQ
# OAkH+Mn71KUCC7iEgfdxL7FUSojrcZs4WXcGFtM+MECp3XUnRo95B9cWhVpbV575
# eFi5GKh8CAbjO3clGGcRL8CvIaOcCw9xYv1ohhYDd5sM+9XdPYV+yccgWCv5XpL7
# 6ZgY+YZXWrysw3NyrmlYb2PqZVDiqw2LUlkkVrT2CaA04mRQ7ADw8MrCWCoCNsCS
# lX9Dj0A8MobvXTS2iDCMCrFPcCUKeN5hgZy+sEEjgoF4sehVYYRSTcIKZQuaNIUD
# oZd1x8T7nrvF+MU4tjXWxbRqvdNHwBCm8qac2cla7V4CUsk++k/RhGqUBIf52n8n
# aJFtrP6zvOiSq6aMj72U6moUOH6eLzz2GD9UFD2tmqSEXfPfK7v7qyizhVU5J21T
# tqLNKBZojfg9GaQOzrt9n2hWcK05xbYWprpiuZDk6kWN1DQPnes=
# =Dmvz
# -----END PGP SIGNATURE-----
# gpg: Signature made Fri Nov 14 16:35:09 2025 GMT
# gpg:                using RSA key C1B8A89510FF7846011C6A799F2CF38AEBDB0AE0
# gpg: Good signature from "Andy Miller <rhuk@mac.com>" [ultimate]
@pmoreno-rodriguez
Merge branch 'getgrav:develop' into feature/missing-field_classes
b817877
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pmoreno-rodriguez @rhukster