Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump google.golang.org/grpc from 1.63.2 to 1.67.0 #2612

Merged
merged 2 commits into from
Sep 25, 2024
Merged

Bump google.golang.org/grpc from 1.63.2 to 1.67.0 #2612

merged 2 commits into from
Sep 25, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 23, 2024 •
edited
Loading

Bumps google.golang.org/grpc from 1.63.2 to 1.67.0.

Release notes

Sourced from google.golang.org/grpc's releases.

Release 1.67.0

Bug Fixes

  • ringhash: when used with multiple EDS priorities, fix bug that could prevent a higher priority from recovering from transient failure. (#7364)

Behavior Changes

  • In accordance with RFC 7540, clients and servers will now reject TLS connections that don't support ALPN. This can be disabled by setting the environment variable GRPC_ENFORCE_ALPN_ENABLED to false (case insensitive). Please file a bug if you encounter any issues with this behavior. The environment variable to revert this behavior will be removed in an upcoming release. (#7535)

Release 1.66.2

Dependencies

  • Remove unintentional dependency on the testing package (#7579)
  • Remove unintentional dependency on the flate package (#7595)

Bug Fixes

  • client: fix a bug that prevented memory reuse after handling unary RPCs (#7571)

Release 1.66.0

New Features

  • metadata: stabilize ValueFromIncomingContext (#7368)
  • client: stabilize the WaitForStateChange and GetState methods, which were previously experimental. (#7425)
  • xds: Implement ADS flow control mechanism (#7458)
  • balancer/rls: Add metrics for data cache and picker internals (#7484, #7495)
  • xds: LRS load reports now include the total_issued_requests field. (#7544)

Bug Fixes

  • grpc: Clients now return status code INTERNAL instead of UNIMPLEMENTED when the server uses an unsupported compressor. This is consistent with the gRPC compression spec. (#7461)
  • transport: Fix a bug which could result in writes busy looping when the underlying conn.Write returns errors (#7394)
  • client: fix race that could lead to orphaned connections and associated resources. (#7390)
  • xds: use locality from the connected address for load reporting with pick_first (#7378)
    • without this fix, if a priority contains multiple localities with pick_first, load was reported for the wrong locality
  • client: prevent hanging during ClientConn.Close() when the network is unreachable (#7540)

Performance Improvements

  • transport: double buffering is avoided when using an http connect proxy and the target server waits for client to send the first message. (#7424)
  • codec: Implement a new Codec which uses buffer recycling for encoded message (#7356)
    • introduce a mem package to facilitate buffer reuse (#7432)

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Sep 23, 2024
@dependabot dependabot bot mentioned this pull request Sep 23, 2024
Closed
@chadlwilson chadlwilson marked this pull request as draft September 23, 2024 23:57
@dependabot
Bump google.golang.org/grpc from 1.63.2 to 1.67.0
73d8ec0 
Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.63.2 to 1.67.0.
- [Release notes](https://github.com/grpc/grpc-go/releases)
- [Commits](grpc/grpc-go@v1.63.2...v1.67.0)

---
updated-dependencies:
- dependency-name: google.golang.org/grpc
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/go_modules/google.golang.org/grpc-1.67.0 branch from 02774a5 to 73d8ec0 Compare September 23, 2024 23:58
@github-actions GitHub Actions
Copy link
Contributor

Benchmark Results

java_maven_parallel.csv

Commit CPU Memory Time ExitCode
209816e 40% 218564 0:34.92 0
684d870 33% 177512 0:34.73 0
afc97cb 33% 172916 0:32.61 0
95ef07f 31% 166692 0:34.32 0

java_maven_multithreaded.csv

Commit CPU Memory Time ExitCode
209816e 59% 210032 0:19.35 0
684d870 58% 183140 0:15.71 0
afc97cb 60% 173792 0:15.06 0
95ef07f 60% 174044 0:15.11 0

java_gradle_serial.csv

Commit CPU Memory Time ExitCode
209816e 10% 126456 0:25.35 0
684d870 10% 130832 0:25.82 0
afc97cb 9% 122360 0:25.03 0
95ef07f 9% 122876 0:25.81 0

java_maven_serial.csv

Commit CPU Memory Time ExitCode
209816e 64% 262080 0:21.98 0
684d870 63% 205604 0:19.21 0
afc97cb 71% 189880 0:17.03 0
95ef07f 66% 171700 0:18.46 0

java_gradle_parallel.csv

Commit CPU Memory Time ExitCode
209816e 5% 128988 0:46.76 0
684d870 5% 116480 0:45.44 0
afc97cb 6% 126520 0:46.25 0
95ef07f 6% 116180 0:41.83 0

java_simple_multithreaded.csv

Commit CPU Memory Time ExitCode
209816e 28% 70148 0:12.10 0
684d870 34% 68012 0:10.56 0
afc97cb 26% 69952 0:13.39 0
95ef07f 30% 63816 0:12.37 0

java_simple_serial.csv

Commit CPU Memory Time ExitCode
209816e 44% 67716 0:14.15 0
684d870 53% 67684 0:11.47 0
afc97cb 40% 65936 0:15.87 0
95ef07f 53% 63796 0:11.83 0

java_simple_parallel.csv

Commit CPU Memory Time ExitCode
209816e 22% 74208 0:25.02 0
684d870 22% 75992 0:24.47 0
afc97cb 23% 73892 0:24.89 0
95ef07f 22% 65748 0:24.94 0

java_gradle_multithreaded.csv

Commit CPU Memory Time ExitCode
209816e 10% 122740 0:22.51 0
684d870 10% 123668 0:24.49 0
afc97cb 10% 97660 0:22.99 0
95ef07f 10% 97564 0:23.02 0

Notes

  • The results above are generated by running against seed projects in https://github.com/getgauge/gauge-benchmark
  • These results are not persisted, but on merging to master the benchmark will be rerun.
  • These benchmark are run in Github Actions' agents, which are virtualized. Results are not to be taken as actual benchmarks.Rather, these are indicative numbers and make sense for comparison.

See Workflow log for more details.

@chadlwilson
Change connections to recommended GRPC async config
6eceb22 
Blocking is deprecated in modern GRPC and it is recommended to connect in the background.

Signed-off-by: Chad Wilson <chadw@thoughtworks.com>
@chadlwilson chadlwilson marked this pull request as ready for review September 25, 2024 03:14
@chadlwilson chadlwilson enabled auto-merge (squash) September 25, 2024 03:15
@chadlwilson chadlwilson merged commit 13cbdda into master Sep 25, 2024
17 checks passed
@chadlwilson chadlwilson deleted the dependabot/go_modules/google.golang.org/grpc-1.67.0 branch September 25, 2024 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chadlwilson chadlwilson chadlwilson approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file go Pull requests that update Go code
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@chadlwilson