Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only install screenshot plugin when screenshot_on_failure is enabled #2387

Merged
merged 2 commits into from
Jul 28, 2023

Conversation

haroon-sheikh
Copy link
Contributor

Fixes #2186

  • Removes screenshot plugin from required plugins
  • Require screenshot plugin only when screenshot_on_failure = true variable is set

Signed-off-by: Haroon Sheikh <haroon.sheikh@sky.uk>
Signed-off-by: Haroon Sheikh <haroon.sheikh@sky.uk>
@haroon-sheikh
Copy link
Contributor Author

Benchmark Results

java_gradle_serial.csv

Commit CPU Memory Time ExitCode
c532320 177% 349640 0:21.11 0
c93f7af 166% 619168 0:33.39 0
e7c5dc7 6% 119700 0:31.42 0
91d0f25 6% 119452 0:35.98 0

java_simple_serial.csv

Commit CPU Memory Time ExitCode
c532320 170% 343216 0:14.42 0
c93f7af 163% 341344 0:15.11 0
e7c5dc7 26% 65580 0:18.79 0
91d0f25 31% 61740 0:14.75 0

java_maven_multithreaded.csv

Commit CPU Memory Time ExitCode
c532320 183% 303728 0:22.61 0
c93f7af 153% 362648 0:37.51 0
e7c5dc7 42% 203644 0:23.39 0
91d0f25 50% 192560 0:21.26 0

java_maven_serial.csv

Commit CPU Memory Time ExitCode
c532320 181% 338348 0:18.11 0
c93f7af 147% 296200 0:30.25 0
e7c5dc7 50% 209008 0:24.03 0
91d0f25 50% 198512 0:31.08 0

java_gradle_multithreaded.csv

Commit CPU Memory Time ExitCode
c532320 182% 355644 0:20.04 0
c93f7af 179% 558492 0:33.83 0
e7c5dc7 6% 120660 0:34.02 0
91d0f25 6% 124152 0:39.38 0

java_simple_multithreaded.csv

Commit CPU Memory Time ExitCode
c532320 174% 384524 0:13.73 0
c93f7af 174% 385536 0:14.13 0
e7c5dc7 26% 66300 0:12.22 0
91d0f25 20% 65604 0:17.20 0

java_simple_parallel.csv

Commit CPU Memory Time ExitCode
c532320 188% 316540 0:20.17 0
c93f7af 182% 324672 0:20.33 0
e7c5dc7 20% 67916 0:23.75 0
91d0f25 22% 65676 0:21.62 0

java_gradle_parallel.csv

Commit CPU Memory Time ExitCode
c532320 178% 374068 0:20.26 0
c93f7af 166% 639544 0:30.80 0
e7c5dc7 5% 121060 0:36.79 0
91d0f25 5% 122976 0:37.48 0

java_maven_parallel.csv

Commit CPU Memory Time ExitCode
c532320 184% 340820 0:20.92 0
c93f7af 158% 341744 0:31.93 0
e7c5dc7 37% 206568 0:42.16 0
91d0f25 36% 197764 0:38.35 0

Notes

  • The results above are generated by running against seed projects in https://github.com/getgauge/gauge-benchmark
  • These results are not persisted, but on merging to master the benchmark will be rerun.
  • These benchmark are run in Github Actions' agents, which are virtualized. Results are not to be taken as actual benchmarks.Rather, these are indicative numbers and make sense for comparison.

See Workflow log for more details.

@gaugebot
Copy link

gaugebot bot commented Jul 28, 2023

@haroon-sheikh Thank you for contributing to gauge. Your pull request has been labeled as a release candidate 🎉🎉.

Merging this PR will trigger a release.

Please bump up the version as part of this PR.

Instructions to bump the version can found at CONTRIBUTING.md

If the CONTRIBUTING.md file does not exist or does not include instructions about bumping up the version, please looks previous commits in git history to see what changes need to be done.

@haroon-sheikh haroon-sheikh merged commit cbb087a into getgauge:master Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Make screenshot plugin optional
1 participant