Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for downloading arm64 binaries #2286

Merged
merged 3 commits into from
Sep 8, 2022
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix lint issues
Signed-off-by: Srikanth <srikanth.ddit@gmail.com>
sriv committed Sep 8, 2022
commit e7befd75e908c3904a930bafb2f8d74df1782f74
9 changes: 3 additions & 6 deletions conn/network_test.go
Original file line number Diff line number Diff line change
@@ -10,7 +10,6 @@ import (
"errors"
"fmt"
"net"
"reflect"
"testing"
"time"

@@ -42,9 +41,7 @@ func (m mockConn) Read(b []byte) (n int, err error) {
}

data := append(proto.EncodeVarint(uint64(len(messageBytes))), messageBytes...)
for i := 0; i < len(data); i++ {
b[i] = data[i]
}
copy(b, data)
return len(data), nil
}

@@ -176,7 +173,7 @@ func TestGetResponseForGaugeMessageShoudGiveErrorForUnsupportedMessage(t *testin

expected := errors.New("Unsupported Message response received. Message not supported.")

if reflect.DeepEqual(err, expected) {
if err != expected {
t.Errorf("expected %v\n got %v", expected, err)
}

@@ -206,7 +203,7 @@ func TestGetResponseForGaugeMessageShoudErrorWithTimeOut(t *testing.T) {
_, err := GetResponseForMessageWithTimeout(message, conn, 1*time.Second)

expected := fmt.Errorf("Request timed out for Message with ID => %v and Type => StepNameRequest", id)
if !reflect.DeepEqual(err, expected) {
if err != expected {
t.Errorf("expected %v\n got %v", expected, err)
}
}