-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
print plugin version #1306
print plugin version #1306
Conversation
update fork
will check failing tests. where do I find this |
@ajoecker Have you been able to look at this PR again? |
@nehashri sorry - unfortunately not. I will probably have time by the end of the week |
sorry for the enormous delay... will start to look at it.. |
the question for this solution is I assume to print only the version information if one is actually present so |
@ajoecker Yes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ajoecker gauge-proto on master seems to be uptodate. any reason why gauge-proto is changed in this PR?
no - no idea why it got updated - not purpose though. is it possible to only revert the changes to gauge-proto ? |
You should be able to do it. In your gauge project, goto the gauge-proto directory and checkout the master branch, pull the latest changes. This should remove the proto changes |
@ajoecker I will merge this PR and create another commit to fix the gauge-proto issue. |
for #1266
introducing a new variable
Version
in theInstallationResult
to not misuse theInfo
variable, as this might contain other information.