Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

print plugin version #1306

Merged
merged 23 commits into from
Mar 27, 2019
Merged

Conversation

ajoecker
Copy link
Contributor

for #1266

introducing a new variable Version in the InstallationResult to not misuse the Info variable, as this might contain other information.

@ajoecker
Copy link
Contributor Author

ajoecker commented Jan 15, 2019

will check failing tests.

where do I find this starttests.sh java and which tests are those, which are failing ?

@nehashri
Copy link
Contributor

@ajoecker Completely missed this PR!!!
The tests that are failing are functional tests for Gauge. They can be found here

@nehashri
Copy link
Contributor

nehashri commented Feb 4, 2019

@ajoecker Have you been able to look at this PR again?

@ajoecker
Copy link
Contributor Author

ajoecker commented Feb 5, 2019

@nehashri sorry - unfortunately not. I will probably have time by the end of the week

@ajoecker
Copy link
Contributor Author

sorry for the enormous delay... will start to look at it..

@ajoecker
Copy link
Contributor Author

ajoecker commented Feb 21, 2019

the question for this solution is I assume to print only the version information if one is actually present

so Failed to install plugin 'unknown' version . should actually be Failed to install plugin 'unknown', right ?

@nehashri
Copy link
Contributor

@ajoecker Yes

Copy link
Contributor

@nehashri nehashri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ajoecker gauge-proto on master seems to be uptodate. any reason why gauge-proto is changed in this PR?

@nehashri nehashri removed the ready label Feb 25, 2019
@ajoecker
Copy link
Contributor Author

ajoecker commented Feb 25, 2019

@ajoecker gauge-proto on master seems to be uptodate. any reason why gauge-proto is changed in this PR?

no - no idea why it got updated - not purpose though.

is it possible to only revert the changes to gauge-proto ?

@nehashri
Copy link
Contributor

You should be able to do it. In your gauge project, goto the gauge-proto directory and checkout the master branch, pull the latest changes. This should remove the proto changes

@gaugebot gaugebot bot added the ready label Mar 4, 2019
@nehashri
Copy link
Contributor

@ajoecker I will merge this PR and create another commit to fix the gauge-proto issue.

@nehashri nehashri merged commit 76a8a6d into getgauge:master Mar 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants