Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not pass os.Stdin to launched command #14

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

bockstaller
Copy link
Contributor

This is related to getgauge/gauge#2419

  • removes problematic line
  • references issue in the code
  • updates the dependencies in order to get go build and go test working

Signed-off by: Lukas Bockstaller lukas.bockstaller@posteo.de

@bockstaller
Copy link
Contributor Author

I am still testing locally to make sure that this fixes the issue for good

@bockstaller bockstaller marked this pull request as draft October 26, 2023 09:02
@haroon-sheikh haroon-sheikh self-requested a review October 26, 2023 10:36
@bockstaller
Copy link
Contributor Author

bockstaller commented Oct 26, 2023

I was able to verify that gauge-ts is working with this version. gauge-python continues to work. But I wasn't able to get a ruby project of the ground and running in order to test gauge-ruby (but that is a ruby and not a gauge-ruby problem)

@haroon-sheikh can you take a look?

@bockstaller bockstaller marked this pull request as ready for review October 26, 2023 11:25
@chadlwilson
Copy link
Contributor

@bockstaller I'll take a look at gauge-ruby to sanity test it, as it's in active use for gocd so I've been maintaining it recently. I was about to bump the golang build version so can bump gauge-common also. Should be fine.

This is related to getgauge/gauge#2419
- removes problematic line
- references issue in the code
- updates the dependencies in order to get go build and go test working

Co-authored-by: Lukas Bockstaller <lukas.bockstaller@posteo.de>
Signed-off-by: Lukas Bockstaller <lukas.bockstaller@posteo.de>
Signed-off-by: Chad Wilson <chadw@thoughtworks.com>
@chadlwilson chadlwilson merged commit b797a8b into getgauge:master Oct 26, 2023
3 checks passed
@chadlwilson
Copy link
Contributor

Rebased off master to separate the fix here from the dependency clean-up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants