-
-
Notifications
You must be signed in to change notification settings - Fork 638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: create multiarch docker image #874
Conversation
efb2d82
to
8f91c1d
Compare
Thanks for the PR and sorry for being slow to respond. I’m new to buildx so I had to do some research. Have you tried this action here before? https://github.com/docker/build-push-action I’d prefer using the official Docker actions if possible. Apparently we could even replace that azure docker login as well (which I honestly don’t know I use that...) |
Hi @goenning, thanks for the response. |
@abemedia thanks for the update. the reason why I went with a separate
|
@goenning still not working as As for the PR images that's being done via |
|
OK, will change that back and update the PR once rogchap/v8go#98 is merged. |
I think we’ll need to wait for rogchap/v8go#223 as well |
I've been using this branch on ARM for months now. All worked fine. |
Oh, thanks! I'll try to build an image from this branch. @abemedia 👍 |
Currently the docker images only work on
amd64
architecture. This PR adds support forarmv7
,arm64
and386
.The versions in the migrate functions are using strings now as the number was too large for 32-bit architectures.