fix: Make Ingestor async-aware
#2022
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It would have been a small change if not for the snowflake connector. Turns out the snowflake client we're currently using is not async-aware. The returned iterator over the table rows from the client is `!Send`. This forces us to change `Connector::start` to return a `!Send` future, which in turn results in big refactoring of all the tests.
karolisg
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would have been a small change if not for the snowflake connector.
Turns out the snowflake client we're currently using is not async-aware. The returned iterator over the table rows from the client is
!Send.This forces us to change
Connector::startto return a!Sendfuture, which in turn results in big refactoring of all the tests.