feat(settings): bridge seller_enable_terms_and_conditions legacy key#3247
Open
akzmoudud wants to merge 2 commits into
Open
feat(settings): bridge seller_enable_terms_and_conditions legacy key#3247akzmoudud wants to merge 2 commits into
akzmoudud wants to merge 2 commits into
Conversation
Add a 'Store Terms and Conditions' switch under Compliance > Privacy that bridges to the legacy dokan_general.seller_enable_terms_and_conditions option via LegacySettingsBridge, so upgraded sites migrate cleanly. Refs #1931
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…at-array' into feat/bridge-legacy-settings-mappings # Conflicts: # includes/Admin/Settings/Schema/SettingsSchema.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
Maps the legacy
dokan_general.seller_enable_terms_and_conditionsoption into the new flat-array settings schema so upgraded sites migrate cleanly throughLegacySettingsBridge.SettingsSchema.php— add a Store Terms and Conditionsswitchfield under Compliance › Privacy (privacy_settingssection), defaultoff, withlegacy_key => dokan_general.seller_enable_terms_and_conditions.This is the Lite half of the
dokan_generalStore T&C mapping; the Pro half (enable_tc_on_reg) ships in the companion Pro PR.Related Pull Request(s)
Closes
How to test the changes in this Pull Request:
admin.php?page=dokan-dashboard) → Compliance › Privacy → toggle Store Terms and Conditions ON → Save.wp option get dokan_general --format=json→seller_enable_terms_and_conditions=on.admin.php?page=dokan) → General › Vendor Store Settings → Store Terms and Conditions reflects the change (verified end-to-end).Changelog entry
Bridge Store Terms and Conditions setting to the new settings schema
Previously the new flat-schema settings had no field mapped to the legacy
dokan_general.seller_enable_terms_and_conditionsoption, so the value wouldn't migrate. This PR adds the mapped field under Compliance › Privacy.After Changes
New UI Store Terms and Conditions toggle saves straight back to the legacy
dokan_generaloption (write-back verified); the old settings page reads it transparently.