Skip to content

bug: Fix llamafile health uri #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kaspermarstal merged 1 commit into from
Sep 19, 2024
Merged

bug: Fix llamafile health uri #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions src/Cellm/Models/Llamafile/LlamafileClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,8 @@ private async Task WaitForLlamafile(Process process)
var cancellationTokenSource = new CancellationTokenSource(TimeSpan.FromSeconds(1));
var startTime = DateTime.UtcNow;

while ((DateTime.UtcNow - startTime).TotalSeconds < 30) // Max 30 seconds timeout
// 30 seconds timeout
while ((DateTime.UtcNow - startTime).TotalSeconds < 30)
{
if (process.HasExited)
{
Expand All @@ -136,10 +137,11 @@ private async Task WaitForLlamafile(Process process)

try
{
var response = await _httpClient.GetAsync($"{_openAiConfiguration.BaseAddress}/health", cancellationTokenSource.Token);
var response = await _httpClient.GetAsync(new Uri(_openAiConfiguration.BaseAddress, "health"), cancellationTokenSource.Token);
if (response.StatusCode == System.Net.HttpStatusCode.OK)
{
return; // Server is healthy
// Server is ready
return;
}
}
catch (TaskCanceledException)
Expand All @@ -149,9 +151,11 @@ private async Task WaitForLlamafile(Process process)
{
}

await Task.Delay(500); // Wait for 500ms before next attempt
// Wait for before next attempt
await Task.Delay(500);
}

process.Kill();
throw new CellmException("Timeout waiting for Llamafile server to be ready");
}
}
Expand Down