fix: show all container ip's in list view#2726
Merged
Merged
Conversation
Contributor
|
Container images for this PR have been built successfully!
Built from commit b30d871 |
f362369 to
b30d871
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Checklist
mainbranchWhat This PR Implements
Fixes: #2725
Changes Made
Testing Done
./scripts/development/dev.sh startjust lint all)just test backendAI Tool Used (if applicable)
AI Tool:
Assistance Level:
What AI helped with:
I reviewed and edited all AI-generated output:
I ran all required tests and manually verified changes:
Additional Context
Disclaimer Greptiles Reviews use AI, make sure to check over its work.
To better help train Greptile on our codebase, if the comment is useful and valid Like the comment, if its not helpful or invalid Dislike
To have Greptile Re-Review the changes, mention
greptileai.Greptile Summary
This PR fixes an issue where containers connected to multiple Docker networks only showed the first network's IP address in the containers list view. It replaces the single-IP helper with a multi-IP variant and updates both the table cell and mobile card renderers to display all IPs.
getContainerIpAddressesnow collects all non-empty, deduplicated IPs across networks, sorted deterministically by network name — replacing the old first-match-wins approach.IPAddressCellandIPAddressesFieldsnippets render a stacked list of IPs (or "N/A") in the table and mobile card views respectively; the mobile field config is updated totype: 'component'with the new snippet passed ascomponent.beforeEachis correctly scoped inside its owndescribeblock to avoid conflicting with the new test's route mock.Confidence Score: 5/5
Safe to merge — the change is additive and well-tested, with no regressions to existing behavior.
The helper function is straightforward and handles all edge cases (no networks, empty IPs, duplicates). The Svelte snippets render correctly in both table and mobile card contexts, and the IPAddressesField snippet already uses a span as its root to stay valid inside the inline span wrapper the mobile card provides in compact mode. The new Playwright test is well-constructed with proper route mocking and verifies both IPs appear in the table row.
No files require special attention.
Reviews (2): Last reviewed commit: "fix: show all container ip's in list vie..." | Re-trigger Greptile