Skip to content

fix: show all container ip's in list view#2726

Merged
kmendell merged 1 commit into
mainfrom
fix/container-ips
May 25, 2026
Merged

fix: show all container ip's in list view#2726
kmendell merged 1 commit into
mainfrom
fix/container-ips

Conversation

@kmendell
Copy link
Copy Markdown
Member

@kmendell kmendell commented May 25, 2026

Checklist

  • This PR is not opened from my fork’s main branch

What This PR Implements

Fixes: #2725

Changes Made

Testing Done

  • Development environment started: ./scripts/development/dev.sh start
  • Frontend verified at http://localhost:3000
  • Backend verified at http://localhost:3552
  • Manual testing completed (describe):
  • No linting errors (e.g., just lint all)
  • Backend tests pass: just test backend

AI Tool Used (if applicable)

AI Tool:
Assistance Level:
What AI helped with:
I reviewed and edited all AI-generated output:
I ran all required tests and manually verified changes:

Additional Context

Disclaimer Greptiles Reviews use AI, make sure to check over its work.

To better help train Greptile on our codebase, if the comment is useful and valid Like the comment, if its not helpful or invalid Dislike

To have Greptile Re-Review the changes, mention greptileai.

Greptile Summary

This PR fixes an issue where containers connected to multiple Docker networks only showed the first network's IP address in the containers list view. It replaces the single-IP helper with a multi-IP variant and updates both the table cell and mobile card renderers to display all IPs.

  • getContainerIpAddresses now collects all non-empty, deduplicated IPs across networks, sorted deterministically by network name — replacing the old first-match-wins approach.
  • New IPAddressCell and IPAddressesField snippets render a stacked list of IPs (or "N/A") in the table and mobile card views respectively; the mobile field config is updated to type: 'component' with the new snippet passed as component.
  • A new Playwright test covers the multi-network IP display case; the existing beforeEach is correctly scoped inside its own describe block to avoid conflicting with the new test's route mock.

Confidence Score: 5/5

Safe to merge — the change is additive and well-tested, with no regressions to existing behavior.

The helper function is straightforward and handles all edge cases (no networks, empty IPs, duplicates). The Svelte snippets render correctly in both table and mobile card contexts, and the IPAddressesField snippet already uses a span as its root to stay valid inside the inline span wrapper the mobile card provides in compact mode. The new Playwright test is well-constructed with proper route mocking and verifies both IPs appear in the table row.

No files require special attention.

Reviews (2): Last reviewed commit: "fix: show all container ip's in list vie..." | Re-trigger Greptile

Copy link
Copy Markdown
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@kmendell kmendell marked this pull request as ready for review May 25, 2026 14:56
@kmendell kmendell requested a review from a team May 25, 2026 14:56
@getarcaneappbot
Copy link
Copy Markdown
Contributor

getarcaneappbot commented May 25, 2026

Container images for this PR have been built successfully!

  • Manager: ghcr.io/getarcaneapp/manager:pr-2726
  • Agent: ghcr.io/getarcaneapp/agent:pr-2726

Built from commit b30d871

Comment thread frontend/src/routes/(app)/containers/container-table.svelte
@kmendell kmendell force-pushed the fix/container-ips branch from f362369 to b30d871 Compare May 25, 2026 15:05
@kmendell kmendell merged commit 5a37347 into main May 25, 2026
28 checks passed
@kmendell kmendell deleted the fix/container-ips branch May 25, 2026 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐞 Bug: Missing IP Addresses on Containers page

2 participants