Skip to content

fix: add missing gRPC/ws tunnel commands#2636

Merged
kmendell merged 1 commit into
mainfrom
fix/missing-grpc-tunnel-commands
May 17, 2026
Merged

fix: add missing gRPC/ws tunnel commands#2636
kmendell merged 1 commit into
mainfrom
fix/missing-grpc-tunnel-commands

Conversation

@kmendell
Copy link
Copy Markdown
Member

@kmendell kmendell commented May 17, 2026

Checklist

  • This PR is not opened from my fork’s main branch

What This PR Implements

Fixes: #2633

Changes Made

Testing Done

  • Development environment started: ./scripts/development/dev.sh start
  • Frontend verified at http://localhost:3000
  • Backend verified at http://localhost:3552
  • Manual testing completed (describe):
  • No linting errors (e.g., just lint all)
  • Backend tests pass: just test backend

AI Tool Used (if applicable)

AI Tool:
Assistance Level:
What AI helped with:
I reviewed and edited all AI-generated output:
I ran all required tests and manually verified changes:

Additional Context

Disclaimer Greptiles Reviews use AI, make sure to check over its work.

To better help train Greptile on our codebase, if the comment is useful and valid Like the comment, if its not helpful or invalid Dislike

To have Greptile Re-Review the changes, mention greptileai.

Greptile Summary

This PR registers 7 previously missing project command routes (compose, files, runtime, updates, file, archive, unarchive) in the edge-tunnel routing table so the tunnel can correctly identify and forward those API calls.

  • commands.go adds 7 new commandRoute entries under the project sub-paths; all use distinct static segments and correct HTTP methods, so there are no routing conflicts with existing entries.
  • commands_test.go adds test cases for only 2 of the 7 new routes (project.updates, project.archive), leaving 5 routes without coverage.

Confidence Score: 4/5

The routing additions are straightforward and low-risk; missing test cases for 5 of the 7 new routes is the only gap.

The change is a narrow, additive fix to a static routing table. All 7 new paths use unique static segments, follow the established pattern, and the existing panic-on-duplicate guard means a mistaken duplicate would be caught at startup. The only weakness is that 5 of the new routes have no test cases, leaving them unguarded against future accidental removal or rename.

commands_test.go — the 5 untested routes (compose, files, runtime, file, unarchive) would benefit from test cases matching the style of the existing suite.

Fix All in Codex Fix All in Claude Code

Prompt To Fix All With AI
Fix the following 1 code review issue. Work through them one at a time, proposing concise fixes.

---

### Issue 1 of 1
backend/pkg/libarcane/edge/commands_test.go:26-27
**Incomplete test coverage for new routes**

Only `project.updates` and `project.archive` are tested among the 7 new routes. The routes `project.compose`, `project.files`, `project.runtime`, `project.file`, and `project.unarchive` have no test cases. Since the existing suite already covers the routing tree mechanic, adding cases for these commands is straightforward and would guard against typos or future accidental deletions from the route table.

Reviews (1): Last reviewed commit: "fix: add missing gRPC/ws tunnel commands" | Re-trigger Greptile

Greptile also left 1 inline comment on this PR.

@kmendell kmendell marked this pull request as ready for review May 17, 2026 20:16
@kmendell kmendell requested a review from a team May 17, 2026 20:16
Copy link
Copy Markdown
Member Author

kmendell commented May 17, 2026

This stack of pull requests is managed by Graphite. Learn more about stacking.

Comment thread backend/pkg/libarcane/edge/commands_test.go
@getarcaneappbot
Copy link
Copy Markdown
Contributor

Container images for this PR have been built successfully!

  • Manager: ghcr.io/getarcaneapp/arcane:pr-2636
  • Agent: ghcr.io/getarcaneapp/arcane-headless:pr-2636

Built from commit fcf688e

@kmendell kmendell merged commit c4fc094 into main May 17, 2026
27 checks passed
@kmendell kmendell deleted the fix/missing-grpc-tunnel-commands branch May 17, 2026 20:31
github-actions Bot added a commit to ShobuPrime/home-assistant-apps that referenced this pull request May 20, 2026
## Arcane Docker Manager Update

This automated PR updates Arcane from `1.16.4` to `1.19.4`.

### Changelog


### Bug fixes

* block unsafe compose include file reads ([#2630](getarcaneapp/arcane#2630) by `kmendell`)
* add missing gRPC/ws tunnel commands ([#2636](getarcaneapp/arcane#2636) by `kmendell`)
* unable to use templates due to 'not found' error ([#2634](getarcaneapp/arcane#2634) by `kmendell`)
* retry rate limited update checks ([#2639](getarcaneapp/arcane#2639) by `kmendell`)
* prevent projects from disappearing when projects folder is unreadable ([#2641](getarcaneapp/arcane#2641) by `kmendell`)
* release notes not populated for manager instance ([#2643](getarcaneapp/arcane#2643) by `kmendell`)

### Other

* publish manager and agent image tags ([#2645](getarcaneapp/arcane#2645) by `kmendell`)
* use trivy-db mirrors from arcane-tools ([#2646](getarcaneapp/arcane#2646) by `kmendell`)



**Full Changelog

### Changes

- Updated `config.yaml` version
- Updated `build.yaml` ARCANE_VERSION
- Updated `Dockerfile` ARCANE_VERSION
- Updated documentation files
- Updated CHANGELOG.md

### Release Notes

Full release notes: https://github.com/getarcaneapp/arcane/releases/tag/v1.19.4

---

This PR was automatically generated by the Update Arcane workflow

Auto-merged by GitHub Actions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐞 Bug:

2 participants