Skip to content

fix: image update checks fail on mobile due to incorrect id#2506

Merged
kmendell merged 1 commit into
mainfrom
fix/image-update-mobile
May 5, 2026
Merged

fix: image update checks fail on mobile due to incorrect id#2506
kmendell merged 1 commit into
mainfrom
fix/image-update-mobile

Conversation

@kmendell
Copy link
Copy Markdown
Member

@kmendell kmendell commented May 5, 2026

Checklist

  • This PR is not opened from my fork’s main branch

What This PR Implements

Fixes: #2498

Changes Made

Testing Done

  • Development environment started: ./scripts/development/dev.sh start
  • Frontend verified at http://localhost:3000
  • Backend verified at http://localhost:3552
  • Manual testing completed (describe):
  • No linting errors (e.g., just lint all)
  • Backend tests pass: just test backend

AI Tool Used (if applicable)

AI Tool:
Assistance Level:
What AI helped with:
I reviewed and edited all AI-generated output:
I ran all required tests and manually verified changes:

Additional Context

Disclaimer Greptiles Reviews use AI, make sure to check over its work.

To better help train Greptile on our codebase, if the comment is useful and valid Like the comment, if its not helpful or invalid Dislike

To have Greptile Re-Review the changes, mention greptileai.

Greptile Summary

The mobile card in container-table.svelte was passing item.id (the container ID) to ImageUpdateItem's imageId prop instead of item.imageId. This caused image update checks to fail on mobile because the wrong ID was being used. The fix brings the mobile path in line with the desktop UpdatesCell snippet, which already used item.imageId.

Confidence Score: 5/5

Safe to merge — single-character fix to a prop value that brings the mobile card in line with the already-correct desktop rendering path.

The change is a minimal, targeted correction to a single prop in the mobile card. It mirrors the desktop snippet's existing behavior and has no side effects on other logic.

No files require special attention.

Reviews (1): Last reviewed commit: "fix: image update checks fail on mobile ..." | Re-trigger Greptile

@kmendell kmendell marked this pull request as ready for review May 5, 2026 00:18
Copy link
Copy Markdown
Member Author

kmendell commented May 5, 2026

This stack of pull requests is managed by Graphite. Learn more about stacking.

@kmendell kmendell requested a review from a team May 5, 2026 00:18
@getarcaneappbot
Copy link
Copy Markdown
Contributor

Container images for this PR have been built successfully!

  • Manager: ghcr.io/getarcaneapp/arcane:pr-2506
  • Agent: ghcr.io/getarcaneapp/arcane-headless:pr-2506

Built from commit c699cd2

@kmendell kmendell merged commit 547c720 into main May 5, 2026
27 checks passed
@kmendell kmendell deleted the fix/image-update-mobile branch May 5, 2026 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐞 Bug: Failed to check image update, failed to get image reference - when on mobile

2 participants