fix: image update checks fail on mobile due to incorrect id#2506
Merged
Conversation
Contributor
|
Container images for this PR have been built successfully!
Built from commit c699cd2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Checklist
mainbranchWhat This PR Implements
Fixes: #2498
Changes Made
Testing Done
./scripts/development/dev.sh startjust lint all)just test backendAI Tool Used (if applicable)
AI Tool:
Assistance Level:
What AI helped with:
I reviewed and edited all AI-generated output:
I ran all required tests and manually verified changes:
Additional Context
Disclaimer Greptiles Reviews use AI, make sure to check over its work.
To better help train Greptile on our codebase, if the comment is useful and valid Like the comment, if its not helpful or invalid Dislike
To have Greptile Re-Review the changes, mention
greptileai.Greptile Summary
The mobile card in
container-table.sveltewas passingitem.id(the container ID) toImageUpdateItem'simageIdprop instead ofitem.imageId. This caused image update checks to fail on mobile because the wrong ID was being used. The fix brings the mobile path in line with the desktopUpdatesCellsnippet, which already useditem.imageId.Confidence Score: 5/5
Safe to merge — single-character fix to a prop value that brings the mobile card in line with the already-correct desktop rendering path.
The change is a minimal, targeted correction to a single prop in the mobile card. It mirrors the desktop snippet's existing behavior and has no side effects on other logic.
No files require special attention.
Reviews (1): Last reviewed commit: "fix: image update checks fail on mobile ..." | Re-trigger Greptile