fix: always show save button on template pages#2402
Merged
kmendell merged 1 commit intoApr 18, 2026
Merged
Conversation
Member
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
kmendell
approved these changes
Apr 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/customize/templates/defaultand/customize/templates/[id]was hidden behind{#if composeValidationReady && envValidationReady}validationReadystaysfalseon initial page load and the button never appears{#if}guard; button is always visible and disabled viadisabled={!canSave}which already enforceshasChanges,validationReady, and!hasErrorsFixes #2387
Test plan
/customize/templates/default— save button is visible but disabled until changes are made/customize/templates/[id]— same behaviourDisclaimer Greptiles Reviews use AI, make sure to check over its work.
To better help train Greptile on our codebase, if the comment is useful and valid Like the comment, if its not helpful or invalid Dislike
To have Greptile Re-Review the changes, mention
greptileai.Greptile Summary
This PR fixes the save button being permanently invisible on template pages after the Monaco → CodeMirror migration, where the linter no longer runs on initial page load so
validationReadystaysfalse. The{#if}visibility guard is removed and the button is always rendered, relying ondisabled={!canSave}which already encodes the same conditions (hasChanges,validationReady, no errors). ThehandleSavefunctions also retain their own defensive guards, so the save action remains safe.Confidence Score: 5/5
Safe to merge — the fix is correct, minimal, and the save action remains properly guarded.
canSavealready encodes all conditions that were in the removed{#if}guard,handleSaveretains its own defensive checks, and the button stays inside the remote-template guard in[id]/+page.svelte. No logic regressions found.No files require special attention.
Reviews (1): Last reviewed commit: "fix: always show save button on template..." | Re-trigger Greptile