Skip to content

ci: pin cargo-hakari to 0.9.38 (unpinned latest 0.9.39 fails hakari on every PR) - #779

Merged
getappz merged 2 commits into
masterfrom
task/597-ci-pin-cargo-hakari-to-0-9-38-unpinned-l
Sep 20, 2026
Merged

getappz merged 2 commits into
masterfrom
task/597-ci-pin-cargo-hakari-to-0-9-38-unpinned-l

Conversation

@getappz

@getappz getappz commented Sep 20, 2026 •

Copy link
Copy Markdown
Owner

I pinned the hakari CI job to cargo-hakari 0.9.38, committed on task/597-ci-pin-cargo-hakari-to-0-9-38-unpinned-l as c18bd49. I haven't pushed it.

The change is one line in .github/workflows/ci.yml: the taiki-e/install-action step now uses tool: cargo-hakari@0.9.38 instead of unpinned cargo-hakari. I added a short comment explaining why and saying to bump the version together with a cargo hakari generate re-run.

Testing:

  • With the local cargo-hakari 0.9.38, cargo hakari generate --diff produced no diff.
  • cargo hakari manage-deps --dry-run reported no operations to perform.
  • cargo hakari verify reported that agentflare-workspace-hack works correctly.
  • I did not run the CI job itself. The @version syntax is standard for install-action, but the first PR run on this branch will confirm it. It also will not show the 0.9.39 failure from before, since the pin now prevents that.

Nothing else pins the version. ci.yml is the only workflow that installs cargo-hakari (security-check.yml and the other workflows don't), and no config file records a hakari version. The hakari job is also listed in the gate job's needs, so the "CI Green" failure was downstream of it and should clear once hakari passes.

Upgrading to 0.9.39 later means regenerating the workspace-hack with the new version and changing the pin in the same PR.


Opened by claude-code on flared:c997d745ae66 for item #597 via agentflare.

Summary by CodeRabbit

  • Chores
    • Updated the continuous integration workflow to use a pinned version of the Hakari tool for more consistent build checks.

Unpinned install pulled v0.9.39, which generates a different workspace-hack
than 0.9.38, failing hakari + CI Green on every PR (item #597).

Agentflare-Agent: claude-code
Agentflare-Branch: task/597-ci-pin-cargo-hakari-to-0-9-38-unpinned-l
Agentflare-Item: 597
Agentflare-Session: 9beee810-244c-4e0d-82c0-5151cef77178
@coderabbitai

coderabbitai Bot commented Sep 20, 2026 •

Copy link
Copy Markdown

Review Change StackReview Change Stack

Warning

Review limit reached

Next included review available in 10 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 2 included reviews currently available. Your 50 included PR review attempts over the past 7 days set your current allowance at 2 reviews per hour.

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Repository: getappz/agentflare/.coderabbit.yaml

Review profile: CHILL

Plan: Essentials

Run ID: 91d66f2c-9887-45e7-9cb2-731352d8dd70

📥 Commits

Reviewing files that changed from the base of the PR and between c18bd49 and 1e80400.

📒 Files selected for processing (2)
  • .github/workflows/ci.yml
  • .github/workflows/ppa-publish.yml

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: getappz/agentflare/.coderabbit.yaml

Review profile: CHILL

Plan: Essentials

Run ID: 284d502c-be11-4273-9a07-1c98ad56f3df

📥 Commits

Reviewing files that changed from the base of the PR and between 2bd8646 and c18bd49.

📒 Files selected for processing (1)
  • .github/workflows/ci.yml

Included review availability: 2 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 3 reviews per hour.


📝 Walkthrough

Walkthrough

The Hakari CI job now installs the pinned cargo-hakari version 0.9.38 instead of an unversioned release.

Changes

Hakari CI Version

Layer / File(s) Summary
Pin cargo-hakari installation
.github/workflows/ci.yml
The Hakari workflow now installs cargo-hakari@0.9.38.

Priority: ➖ Normal

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Bug fix

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely identifies the main change: pinning cargo-hakari to version 0.9.38 to avoid failures from the unpinned version.
Description check ✅ Passed The description explains the change, reason, local test results, CI limitation, risk, and upgrade guidance. It does not use the template headings or checkbox format, but it contains the required infor…
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@getappz

getappz commented Sep 20, 2026

Copy link
Copy Markdown
Owner Author

Claiming self-repair for flared:c997d745ae66.

@getappz

getappz commented Sep 20, 2026

Copy link
Copy Markdown
Owner Author

supervisor — CI self-repair dispatched

Failing checks: zizmor.

Please investigate and push a fix.

job: Vi9_bIhWdJEqBhpLMptMa

…ostor-commit)

4360b525 is orphaned (dtolnay force-rewrites the stable branch). Pin to
02cb101e (v1 tag, on master) and pass toolchain: stable explicitly.

Agentflare-Agent: claude-code
Agentflare-Branch: task/597-ci-pin-cargo-hakari-to-0-9-38-unpinned-l
Agentflare-Item: 597
Agentflare-Session: 20214f7d-6a58-49ad-847f-5c790e293d5f
@getappz

getappz commented Sep 20, 2026

Copy link
Copy Markdown
Owner Author

supervisor — CI green

Checks are passing again.

@getappz
getappz merged commit 498cbaa into master Sep 20, 2026
17 checks passed
@getappz
getappz deleted the task/597-ci-pin-cargo-hakari-to-0-9-38-unpinned-l branch September 20, 2026 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant