Repository navigation
Conversation
gc_orphans: retry remove_dir_all with exponential backoff, fall back to cmd /c rmdir, detect locking process via handle64.exe. cleanup-branches.sh: retry git worktree remove on Permission denied with backoff; distinguish dirty vs locked; warn and fall through on lock so branch cleanup is not blocked. Item #302: git worktree remove --force .worktrees/ fails with Permission denied on Windows when rust-analyzer holds file handles. Agentflare-Agent: 1 Agentflare-Branch: feat/worktree-audit-294
|
Warning Review limit reached
Next review available in: 51 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Jul 22, 2026
Agentflare-Agent: claude-code_2-1-217_agent Agentflare-Branch: task/308 Agentflare-Item: 308
Agentflare-Agent: claude-code_2-1-217_agent Agentflare-Branch: task/308 Agentflare-Item: 308
getappz
enabled auto-merge (squash)
July 22, 2026 15:54
This was referenced Oct 5, 2026
getappz
added a commit
that referenced
this pull request
Oct 6, 2026
…dow log, argv-error cooldown (#308) (#870) * wip(sdd-loop): task 0 checkpoint Agentflare-Branch: task/308-usage-threshold-failover-treats-70-weekl Agentflare-Item: 308 * docs+fmt: document failover metadata/config keys, fix cargo fmt drift Adds an "Automatic failover" section to the `agentflare work` CLI docs covering the `"failover"`/`"allowed_agents"` item-metadata keys and the `[failover]` config.toml table (usage_threshold_percent, five_hour_percent, seven_day_percent), per item #308's acceptance criteria. Also runs `cargo fmt` to clean up formatting drift left in the prior checkpoint. Agentflare-Agent: claude-code Agentflare-Branch: task/308-usage-threshold-failover-treats-70-weekl Agentflare-Item: 308 Agentflare-Session: 31ba6896-9f51-43f4-9062-92c8e073cfc6 * fix: preserve branches when worktree cleanup fails Agentflare-Branch: task/308-usage-threshold-failover-treats-70-weekl Agentflare-Item: 308 Agentflare-Session: bb396fc0-d442-4982-b50b-b58e444833e4 * test: create cleanup fixture worktree from HEAD Agentflare-Branch: task/308-usage-threshold-failover-treats-70-weekl Agentflare-Item: 308 * Review completed; fixture fix 2749048 and shell checks passed. Outstanding: partial worktree deletion on removal failure and branch mismatch. Review issues remain: partial worktree deletion on permission failure; fixture fix 2749048 is on task/308 rather than the named PR branch. Commit 082215e skips checked-out worktrees and preserves loose-branch cleanup; focused test, Bash syntax, and diff checks passed. Review of scope and branch mismatch pending. Partial deletion path addressed and focused test passed. Commits 2749048 and 082215e remain on task/308; feat/worktree-audit-294 is absent locally. Safety fix 082215e passed the focused test. PR #306 is closed; feat/worktree-audit-294 is absent locally and remotely. Await corrected PR or branch target. Safety fix 082215e and focused test passed on task/308. PR #306 is closed; feat/worktree-audit-294 is absent locally and remotely. Await corrected target. Code fix 082215e is committed and the focused test passes. Stop retrying this task until a corrected PR or branch target is supplied. Stop fix and review rounds. Tested fix 082215e is on task/308; a corrected PR or branch target is required. Park PR-target mismatch pending a corrected target. Fix 082215e remains committed and tested on the claimed task/308 branch. Skip stale PR #306 task. Preserve tested commits 2749048 and 082215e on task/308 for a correctly targeted follow-up. Agentflare-Branch: task/308-usage-threshold-failover-treats-70-weekl Agentflare-Item: 308 * fix(failover): validate thresholds and narrow argv failures --------- Co-authored-by: shiva <shiva@gosysinfo.tech>
getappz
added a commit
that referenced
this pull request
Oct 6, 2026
… report review_result (#882) * wip(sdd-loop): task 0 checkpoint Agentflare-Branch: task/308-usage-threshold-failover-treats-70-weekl Agentflare-Item: 308 * docs+fmt: document failover metadata/config keys, fix cargo fmt drift Adds an "Automatic failover" section to the `agentflare work` CLI docs covering the `"failover"`/`"allowed_agents"` item-metadata keys and the `[failover]` config.toml table (usage_threshold_percent, five_hour_percent, seven_day_percent), per item #308's acceptance criteria. Also runs `cargo fmt` to clean up formatting drift left in the prior checkpoint. Agentflare-Agent: claude-code Agentflare-Branch: task/308-usage-threshold-failover-treats-70-weekl Agentflare-Item: 308 Agentflare-Session: 31ba6896-9f51-43f4-9062-92c8e073cfc6 * fix: preserve branches when worktree cleanup fails Agentflare-Branch: task/308-usage-threshold-failover-treats-70-weekl Agentflare-Item: 308 Agentflare-Session: bb396fc0-d442-4982-b50b-b58e444833e4 * test: create cleanup fixture worktree from HEAD Agentflare-Branch: task/308-usage-threshold-failover-treats-70-weekl Agentflare-Item: 308 * Review completed; fixture fix 2749048 and shell checks passed. Outstanding: partial worktree deletion on removal failure and branch mismatch. Review issues remain: partial worktree deletion on permission failure; fixture fix 2749048 is on task/308 rather than the named PR branch. Commit 082215e skips checked-out worktrees and preserves loose-branch cleanup; focused test, Bash syntax, and diff checks passed. Review of scope and branch mismatch pending. Partial deletion path addressed and focused test passed. Commits 2749048 and 082215e remain on task/308; feat/worktree-audit-294 is absent locally. Safety fix 082215e passed the focused test. PR #306 is closed; feat/worktree-audit-294 is absent locally and remotely. Await corrected PR or branch target. Safety fix 082215e and focused test passed on task/308. PR #306 is closed; feat/worktree-audit-294 is absent locally and remotely. Await corrected target. Code fix 082215e is committed and the focused test passes. Stop retrying this task until a corrected PR or branch target is supplied. Stop fix and review rounds. Tested fix 082215e is on task/308; a corrected PR or branch target is required. Park PR-target mismatch pending a corrected target. Fix 082215e remains committed and tested on the claimed task/308 branch. Skip stale PR #306 task. Preserve tested commits 2749048 and 082215e on task/308 for a correctly targeted follow-up. Agentflare-Branch: task/308-usage-threshold-failover-treats-70-weekl Agentflare-Item: 308 * fix(failover): validate thresholds and narrow argv failures --------- Co-authored-by: shiva <shiva@gosysinfo.tech>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Supersedes #306, which is stuck in a
CONFLICTINGstate — its branch (feat/worktree-audit-294) still carries the pre-squash commit history of the already-merged #294/#304, diverging from master's squashed version at the git-object level (no actual content conflict, just incompatible history). Rebuilding cleanly on current master instead of fighting that.Cherry-picked the one genuinely new commit from that branch and fixed two gaps found in review:
eprintln!wasn't rustfmt-clean — CI'sfmtjob would have failed had it run (it never did on fix: resilient worktree removal on Windows file-lock (#302) #306, blocked by the CONFLICTING status; only CLA/CodeQL/CodeRabbit reported).remove_worktree_dir(retry + backoff,cmd /c rmdirfallback,handle64.exe/handle.exelocking-process detection) had zero test coverage. Added two: a happy-path removal, and a genuine lock-then-release test (opens a file handle, drops it from a background thread after 250ms, asserts the retry loop succeeds within budget) — meaningful on Windows where an open handle actually blocksremove_dir_all; harmless no-op assertion on Unix where it doesn't.Changes (from item #302)
remove_worktree_dir()ingc_orphans: retryremove_dir_allwith exponential backoff (100ms-1.6s, ~3.1s total + one final attempt), fall back tocmd /c rmdir /s /qon Windows, then tryhandle64.exe/handle.exe(Sysinternals, if present — fails gracefully viaCommand'sErrpath if not installed) to report the locking process.cleanup-branches.sh: retrygit worktree removeup to 5x with backoff, distinguish a genuine lock (Permission denied) from dirty/uncommitted (never retried, still skipped immediately), warn and fall through on a persistent lock instead of blocking the rest of the cleanup run.Test plan
cargo test -p flare-git-core— 98/98 pass (2 new)cargo fmt --all -- --check— cleancargo clippy -p flare-git-core --all-targets --all-features -- -D warnings -A unsafe_code -A clippy::pedantic— cleanbash -n scripts/cleanup-branches.sh— syntax valid (shellcheck not available in this environment)Note for reviewers
cmd /c rmdirreceives the worktree path as aCommand::args()element (not shell-concatenated), butcmd.exeitself still parses%...%/&/|inside whatever it receives. Not fixed here — worktree paths in this codebase are always internally constructed fromrepo_root+ a numericsequence_id/branch-derived name, never external/untrusted input, so real-world exploitability is effectively nil. Flagging for the record rather than adding defensive escaping for a threat model that doesn't apply.