Skip to content
This repository was archived by the owner on Sep 17, 2022. It is now read-only.

Conversation

@aviflax
Copy link
Contributor

@aviflax aviflax commented Sep 17, 2020

Description

I was having trouble getting keysOnly to work, after staring at the examples for awhile I noticed that they use keys_only — so I looked at the source and found that, yes, the YAML tag for this field is keys_only. So I figured we should fix the reference.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have performed a self-review of my own code
  • Go code is formatted with gofmt (N/A)
  • I have made corresponding changes to the docs in /docs and in the README (N/A)
  • I have added tests (unit and/or end-to-end) that prove my fix is effective or that my feature works (N/A)
  • Any dependent changes have been merged and published (in downstream modules) (N/A)

Copy link
Collaborator

@dimitarvdimitrov dimitarvdimitrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thank you for handling this! 👍 I will release this by the end of the week.

@dimitarvdimitrov dimitarvdimitrov merged commit 90671a1 into getapid:master Sep 18, 2020
@aviflax aviflax deleted the patch-1 branch September 18, 2020 14:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants