Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use latest webln if available in globalThis after init #96

Merged
merged 2 commits into from
Oct 19, 2023

Conversation

im-adithya
Copy link
Member

Title

@bumi
Copy link
Contributor

bumi commented Oct 19, 2023

hmm... should we use the global webln? or shouldn't webln be passed in?

@rolznz
Copy link
Contributor

rolznz commented Oct 19, 2023

@bumi currently the issue is the webln object on the Lightning Address is being set on init, which breaks if Bitcoin Connect sets webln after the Lightning Address is created. (this needs to be fixed, I asked @im-adithya to make this change already)

this.options = { proxy: DEFAULT_PROXY, webln: globalThis.webln }; should not set webln by default

@rolznz
Copy link
Contributor

rolznz commented Oct 19, 2023

hmm... should we use the global webln? or shouldn't webln be passed in?

I think it is good to fallback to the global webln if you don't pass one in?

Copy link
Contributor

@rolznz rolznz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@rolznz rolznz merged commit 2294939 into master Oct 19, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants