feat: pay 0-amount invoices #860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
you know how much I like zero-amount invoices :D will this work with the supported backends or will this need more |
im-adithya
reviewed
Dec 13, 2024
Adds 0 amount invoices for LND
im-adithya
approved these changes
Dec 13, 2024
rolznz
commented
Dec 16, 2024
|
"NOTE: there is no plan to add support for creating 0-amount invoices." why? |
|
@SoulReaver-SS we believe lightning addresses are a better solution than 0-amount invoices |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #75
Currently only implemented in LDK. Includes a new screen for entering the amount (the same as the LNURL one, just without the ability to set a comment)
Tested by running 2 nodes locally and generating a 0-amount invoice from one and paying with the other. NOTE: there is no plan to add support for creating 0-amount invoices.