feat: redesign first channel payment UI #819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MoritzKa
reviewed
Nov 22, 2024
| @@ -110,7 +110,7 @@ export function FirstChannel() { | |||
| {new Intl.NumberFormat().format(channelSize)} sats of incoming | |||
There was a problem hiding this comment.
Why is in the screenshot provided of this PR 100 sats instead of 100,000 sats in this phrase.
There was a problem hiding this comment.
Ah, when I was developing I mocked some values as the Megalith Mutinynet LSP service was down.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #723
Includes a link to @jpl-btc 's guide for people who do not know how to pay the invoice.
Bitcoin Connect is used in other places, however this is the most important place to improve. Bitcoin Connect should be removed in a follow-up PR.