Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show pending and failed outgoing transactions #682

Merged
merged 5 commits into from
Sep 20, 2024

Conversation

rolznz
Copy link
Contributor

@rolznz rolznz commented Sep 20, 2024

Fixes #426

Failed and unsettled outgoing transactions are now shown in the transaction list. Pending transactions have a pulse animation.

I also added an alert on the send page if the user has any pending payments, to avoid the chance they accidentally try pay again.

Note: Listing transactions is now ordered by updated_at rather than settled_at, created_at

image

image

image

image

image

image

image

TODOs:

  • fix ordering (settled at is an issue for unpaid payments)
  • should transactions that have expired (unsettled after expiration of the invoice) be updated to failed?
  • support params for NIP-47 so Alby Go can do the same

@rolznz
Copy link
Contributor Author

rolznz commented Sep 20, 2024

I've also updated #380 which I think we need two things:

  • splitting unpaid into outgoing and incoming
  • including the transaction state in the transaction object (settled, pending, failed)

@rolznz rolznz merged commit e6f1d5b into master Sep 20, 2024
8 of 9 checks passed
@rolznz rolznz deleted the feat/pending-failed-outgoing-transactions branch September 20, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show pending payments
1 participant