Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: set token for olympus LSP #665

Merged
merged 1 commit into from
Sep 20, 2024
Merged

chore: set token for olympus LSP #665

merged 1 commit into from
Sep 20, 2024

Conversation

rolznz
Copy link
Contributor

@rolznz rolznz commented Sep 19, 2024

No description provided.

@rolznz rolznz requested a review from bumi September 19, 2024 03:27
@rolznz rolznz added this to the v1.9.0 milestone Sep 20, 2024
@kaloudis
Copy link

LGTM

Copy link
Contributor

@bumi bumi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. :shipit:

@@ -230,14 +230,19 @@ func (api *api) requestLSPS1Invoice(ctx context.Context, request *LSPOrderReques
requiredChannelConfirmations = 6
}

token := ""
if request.LSPUrl == "https://lsps1.lnolymp.us/api/v1" {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we break things if we do that for all?

@rolznz rolznz merged commit bfb79a3 into master Sep 20, 2024
9 checks passed
@rolznz rolznz deleted the chore/olympus-token branch September 20, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants