fix: lnurl pay to use existing lightning address #660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
im-adithya
reviewed
Sep 18, 2024
| const lnAddress = new LightningAddress(lnurlDetails.identifier); | ||
| // this is set instead of calling fetch because | ||
| // requestInvoice uses lnurlpData.callback | ||
| lnAddress.lnurlpData = lnurlDetails; | ||
| const invoice = await lnAddress.requestInvoice({ |
There was a problem hiding this comment.
I tried doing this first but for some weird reason this function was not being passed to this screen via state, but somehow it works for me now 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #650
@im-adithya how it was implemented before was very unstable. We should avoid editing internals and instead use the public API of the object.