Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Alby Account Optional #639

Merged
merged 17 commits into from
Sep 12, 2024
Merged

Make Alby Account Optional #639

merged 17 commits into from
Sep 12, 2024

Conversation

rolznz
Copy link
Contributor

@rolznz rolznz commented Sep 11, 2024

Fixes #484

This makes Alby Hub usable without an account by replacing the forced auth with an optional connect flow, and a way to disconnect from the settings. Alby Account specific cards and onboarding steps are removed from the UI.

TODOs:

  • suggestions API is not usable without an Alby Account
  • first channel flow redirects to channels/incoming - added illustration, but no "first channel" copy - I think this is ok for now?
  • new connect account page needs a design iteration - moved to new issue: Improve Connect Alby Account page #642
  • review copy around connecting/disconnecting account
  • fix version check - does not show out of date, just the current version, and there is no link to update.
  • satoshi nakamoto name is weird but is a subtle way to motivate users to connect their account for customization
  • automatic re-auth if you already had an Alby Account with an expired refresh token
  • update to use new Alby info endpoint https://getalby.com/api/internal/info

@rolznz rolznz added this to the v1.8.0 milestone Sep 11, 2024
Copy link
Contributor

@reneaaron reneaaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! 💯

Most of the things work like a charm, however when I try to re-connect my account I seem to be stuck in a redirect loop: (might be related to my dev setup?)

alby/alby_oauth_service.go Outdated Show resolved Hide resolved
@rolznz rolznz changed the title feat: optional Alby Account (WIP) Make Alby Account Optional Sep 12, 2024
@rolznz rolznz marked this pull request as ready for review September 12, 2024 09:41
@rolznz rolznz merged commit 63cd230 into master Sep 12, 2024
9 checks passed
@rolznz rolznz deleted the feat/optional-alby-account branch September 12, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make Alby Account Optional
2 participants