New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add send to lightning address #520

Merged

rolznz merged 20 commits into master from task-send

Aug 27, 2024

Member

im-adithya commented Aug 21, 2024

Description

Fixes #436

Screenshots

Tests

Check with apple23 (random string)
Check with lnbc34567 (invalid bolt11)
Check with expired bolt11
Check with a@a.com (invalid lightning address)
Check with comment length more than commentAllowed while sending to LN address
Check alerts when amounts are greater than balance


          feat: add send to lightning address

f8c270a

im-adithya requested review from rolznz and reneaaron

August 21, 2024 08:32

im-adithya commented

View reviewed changes

frontend/vite.config.ts Show resolved Hide resolved


          chore: update csp in http_service

454d6a5

rolznz reviewed

View reviewed changes

frontend/src/screens/wallet/Send.tsx Outdated Show resolved Hide resolved

rolznz reviewed

View reviewed changes

frontend/src/screens/wallet/Send.tsx Outdated Show resolved Hide resolved

rolznz reviewed

View reviewed changes

frontend/src/screens/wallet/Send.tsx Outdated Show resolved Hide resolved

rolznz reviewed

View reviewed changes

frontend/src/screens/wallet/Send.tsx Outdated Show resolved Hide resolved

rolznz reviewed

View reviewed changes

frontend/src/components/wallet/BalanceCard.tsx Outdated Show resolved Hide resolved

rolznz reviewed

View reviewed changes

frontend/src/components/wallet/LnurlPay.tsx Outdated Show resolved Hide resolved

rolznz reviewed

View reviewed changes

frontend/src/screens/wallet/Send.tsx Outdated Show resolved Hide resolved

rolznz reviewed

View reviewed changes

frontend/src/screens/wallet/Send.tsx Outdated Show resolved Hide resolved

Contributor

rolznz commented Aug 23, 2024

@im-adithya nice work and good attempt to split up the components, but please be careful when refactoring and consider the implications.

I also think there are a few strange things in how the payment components are structured, which I have commented on, but overall I think it is in a good direction.

rolznz added this to the v1.7.0 milestone

im-adithya added 8 commits

August 26, 2024 19:15


          chore: refactor


          chore: remove regexes

c539e5c


          Merge branch 'master' into task-send

ee6680e


          chore: pass lnurlpresponse in state

f856dcf


          chore: remove comments

bb9e853


          chore: avoid multiple calls to fetch

17b807f


          chore: rename Send folder

2ab2279


          chore: get recipient from param

d13e53c

im-adithya force-pushed the task-send branch from 5eb3a41 to d13e53c Compare

August 26, 2024 15:34

Member Author

im-adithya commented Aug 26, 2024

frontend/src/screens/wallet/Send folder should be renamed to frontend/src/screens/wallet/send for the tests to pass. I can't do it for some reason :(

rolznz reviewed

View reviewed changes

frontend/src/components/layouts/SendLayout.tsx Outdated Show resolved Hide resolved


          fix: rename send

8b5880d

rolznz reviewed

View reviewed changes

frontend/src/screens/wallet/send/LnurlPay.tsx Outdated Show resolved Hide resolved

rolznz reviewed

View reviewed changes

frontend/src/screens/wallet/Send.tsx Outdated Show resolved Hide resolved


          fix: balance card

ca18f37

im-adithya and others added 5 commits

August 27, 2024 16:40


          chore: change error message

2992deb


          chore: dry up lnurlpay and redirect if state is empty

d8dd857


          chore: simplify numberformat usage

f2e2b31


          fix: amount formatting on confirm payment page

628d522


          chore: ensure preimage in pay response

af08c16

rolznz approved these changes

View reviewed changes

Contributor

rolznz left a comment

tACK

rolznz and others added 3 commits

August 27, 2024 19:20


          fix: unreliable multi pay invoice controller test

bd5bb10


          fix: unreliable multi pay invoice controller test

c570032


          chore: remove recipient param

e5c6af1

rolznz merged commit 7e8da27 into master

8 checks passed

rolznz deleted the task-send branch

August 27, 2024 13:12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet