fix: use workdir for temp bkp file #511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bumi
reviewed
Aug 19, 2024
rolznz
reviewed
Aug 19, 2024
rolznz
changed the title
|
@im-adithya what tests did you do for this?
what was the issue? |
I was referring to the screenshot you posted in #391
But it is an old version so i think this fix should solve the problem |
|
@im-adithya can you re-review your code and test it again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #391
I failed to see the "failed to create decrypted reader" error as shown in the issue comment, but it should be good as I tested it twice (and saw only the below issue)
This PR solves the issue which gives the "failed to create temporary output file: operation not permitted" error because the directory being used is outside the permitted directory
Tests