-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: move events to transactions service #510
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolznz
changed the title
feat: move events to transactions service (WIP)
feat: move events to transactions service
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #350
Fixes #515
Fixes #516
Fixes #322
Fixes #422
This PR enable notifications for self payments, and keysend self-payments.
ln clients that do not support notifications will not receive events currently because the app connections won't have the permission.
Notable changes
NIP-47 notifications are fired for lnclients that do not support notifications (using fallback method of checking unsettled transactions) - but they are currently filtered out due to the apps not having permission to fire them.failure_reason
TODOs
payment_sent
and onepayment_failed
event, but triggered from transaction service. - the lnclient ones should be renamed to be clearly different.