feat: show tlv records in transaction popup

[im-adithya]

Fixes #31
Fixes #372
Adds custom record info in the transaction popup

Screenshot

[bumi]

I am not sure how the data processing works there. can we get that message on the transaction list? where we have the "description" ? cc @rolznz

[im-adithya]

Yes we can, but we have to discuss on the priority order
For example boostagram > keysend message > description

[rolznz]

Yes we can, but we have to discuss on the priority order
For example boostagram > keysend message > description

Sounds good (and the description would be empty in this case I think anyway)

[bumi]

but we would need to persist that data in the DB. we should not on the fly always decode those keysends.

that's why we have the DB. prepare the data as our app needs it.

[rolznz]

@bumi @im-adithya I think we should go with Bumi's recommendation, right?

@im-adithya would you like to propose the changes you would make? or how should we proceed here?

[im-adithya]

TODOs

• Fix/Add tests
• Store proper description (boostagram > keysend message > description) in db

[rolznz]

I actually don't think we should do this on nwc_payment_sent because we already save the metadata when we initiate the payment

[im-adithya]

Not that important but what if payments happen outside (they don't have metadata since it is a payment, atleast in LND but still I thought it was good to have if we are anyways adding metadata)

Also we should DRY up the "brand new" lnClient.Transaction processing because it is almost the same in both sent/received

[rolznz]

I decided to remove it for now - we need to confirm if we want to add this support and if so, also import transactions from LND (all this is a lot of extra work and code to do properly)

[rolznz]

Example queries:

SELECT *
FROM transactions
WHERE EXISTS (
    SELECT 1
    FROM json_each(metadata, '$.tlv_records') AS records
    WHERE json_extract(records.value, '$.type') = 7629169
);

SELECT *
FROM transactions
WHERE json_extract(boostagram, '$.value_msat') > 1000;

[rolznz]

Roland's tests (WIP):

• migration with transactions with both metadata and no metadata
• query of metadata from migrated transactions
• query of metadata from new transactions
• querying boostagrams
• send boostagram
• receive boostagram
• view boostagram info - sent
• view boostagram info - receive
• NIP-47 lookup invoice / list transactions / notifications returns correct content

[rolznz]

@im-adithya why do some have omitempty others not? is it required?

[im-adithya]

I took this from LBE repo here, whereever we have ?: in the Boostagram type there, I've omitted

[rolznz]

but it looks completely arbitrary and doesn't seem to follow the spec - https://github.com/lightning/blips/blob/master/blip-0010.md#fields

[rolznz]

tACK