Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add back button in setup screen #337

Merged
merged 3 commits into from
Jul 25, 2024
Merged

feat: add back button in setup screen #337

merged 3 commits into from
Jul 25, 2024

Conversation

im-adithya
Copy link
Member

Fixes #310

Screenshot

Screenshot 2024-07-25 at 7 23 03 PM

@im-adithya im-adithya requested a review from rolznz July 25, 2024 13:53
@rolznz
Copy link
Contributor

rolznz commented Jul 25, 2024

@im-adithya this is for Wails/Desktop mode where it has no browser navigation, so shouldn't we always have a back button in that case (on every page)?

Therefore, it also doesn't need to be shown in non-desktop mode

@im-adithya
Copy link
Member Author

It felt weird to have a back button in /welcome and /setup/finish as there is no point in navigating there.

Is that what you mean or you mean for all pages in general? I only added the back button here because in all the other places we either provide breadcrumbs or the sidebar for the user to go to the previous page. Shouldn't that be good?

@rolznz
Copy link
Contributor

rolznz commented Jul 25, 2024

@im-adithya sounds good and fixes the main issue. But I think we should whitelist, not blacklist pages since you missed some:

image

@rolznz
Copy link
Contributor

rolznz commented Jul 25, 2024

@im-adithya I pushed a fix, can you check it?

Copy link
Contributor

@rolznz rolznz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@rolznz rolznz merged commit e136b23 into master Jul 25, 2024
8 checks passed
@rolznz rolznz deleted the task-add-back branch July 25, 2024 14:27
@im-adithya
Copy link
Member Author

I pushed a fix, can you check it?

Looks better now, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add back button in Wails app
2 participants