Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new first channel flow #324

Merged
merged 24 commits into from
Jul 25, 2024
Merged

feat: new first channel flow #324

merged 24 commits into from
Jul 25, 2024

Conversation

rolznz
Copy link
Contributor

@rolznz rolznz commented Jul 23, 2024

Closes #313

The checklist item now goes to a new "first channel" page which uses the Alby LSP proxy to request an order. If Alby doesn't pay the invoice, the user will be directed to the channel order page to pay it. Otherwise, they simply wait for the channel to be opened. On the channel success page, the user's remaining funds will automatically be sent to their new channel.

Using a LSP is now the primary flow, with a link added to go to the outgoing channel flow.

TODOs:

  • Improve First Channel page design
  • Add links to use onchain / fiat from LSPS1 order page
  • Test unpaid private channel open (mutinynet)
  • Test unpaid public channel open (mutinynet)
  • Full test with production network + drained funds
  • Full test with free channel (paid by subscription) - cannot be done as part of this PR
  • Retest original (advanced) LSPS1 flow - should not be affected
  • "Buy or Deposit" is wrong - it goes to increase spending capacity flow
  • Move migration of shared alby funds to new flow

@rolznz rolznz requested review from bumi and reneaaron July 23, 2024 12:28
@rolznz rolznz marked this pull request as ready for review July 25, 2024 13:31
@rolznz rolznz merged commit b86c39d into master Jul 25, 2024
8 checks passed
@rolznz rolznz deleted the feat/first-channel branch July 25, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use a LSPS1 provider instead of PMLSP for Alby shared node funds migration to open first channel
2 participants