Skip to content

Conversation

@rolznz
Copy link
Contributor

@rolznz rolznz commented Jan 31, 2026

This PR also fixes a bug where we will fail saying the invoice has already been paid (I think would block wrapped invoices working with LND right now)

TODOs

  • undo expiry hack and regenerate invoices
  • test in sandbox locally (both wrapped and normal HOLD invoices)
  • test with LND (Polar)
  • test standard HOLD invoices with LDK (Mutinynet) NOTE: wrapped invoices are not supported yet by LDK-Node.
  • test keysend self-payments

Follow ups - move to new issue:

  • update Alby Hub to support setting the min_final_cltv_expiry_delta via nwc (needs exposing in our ldk node fork)

@rolznz rolznz added this to the v1.22.0 milestone Jan 31, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 31, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

  • 🔍 Trigger a full review
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/self-payments-wrapped-invoice

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants