-
Notifications
You must be signed in to change notification settings - Fork 93
Fix: adjust button layout to prevent overlap in ZapPlanner #2023
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Fix: adjust button layout to prevent overlap in ZapPlanner #2023
Conversation
📝 WalkthroughWalkthroughThe ZapPlanner dialog trigger Button gains accessibility and responsive tweaks: an Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@frontend/src/screens/internal-apps/ZapPlanner.tsx`:
- Around line 358-362: The icon-only Button with PlusCircleIcon and className
"max-lg:size-9" lacks an accessible name on small screens; add an accessible
label by adding aria-label="New Recurring Payment" to the Button element (or
alternatively include a screen-reader-only span such as <span
className="sr-only">New Recurring Payment</span>) while keeping the visible
<span className="hidden lg:inline"> for large screens so the button remains
accessible to assistive tech.
|
@kanishka0411 thanks for the PR. Could you add "Fixes # (issue number)" in the description? |
|
Done |
Fixes #1816
Makes the "New Recurring Payment" button responsive by showing only the icon on smaller screens to prevent layout overlap.
Summary by CodeRabbit
Style
Chores
✏️ Tip: You can customize this high-level summary in your review settings.