feat: remove hasLdkDir check #2014
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolznz
reviewed
Jan 12, 2026
| // TODO: remove hasLdkDir check after 2025/01/01 | ||
| // to give time for users to update to 1.6.0+ | ||
| nodeLastStartTime, _ := cfg.Get("NodeLastStartTime", "") | ||
| ldkDir, err := os.Stat(path.Join(cfg.GetEnv().Workdir, "ldk")) |
Contributor
There was a problem hiding this comment.
Thanks for the PR.
On the line above, could we also check the error rather than ignoring it with _.
Author
There was a problem hiding this comment.
check the error
@rolznz, no problem. Should the function log the error and return false or should it pass the error to the caller?
Contributor
There was a problem hiding this comment.
Passing the error would be great, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing #1979