Bug: Doubled incoming balance after closing channel (LDK)

[rolznz]

[jpl-btc]

This had a follow up -> The visualization bug part 2:
Finally those funds were settled and are in my Savings Balance.
However, it seems The Pending Closed Channels notification, continue to be there, and there is a ghost sum of exactly half of what appeared before on the incomings sats small grey section of the Savings Balance box.

[jpl-btc]

Part 3: After some blocks confirmations, the problems of part 2 disappeared. And now everything is as it should be.

[rolznz]

There is probably some overlap in LightningBalances and PendingBalancesFromChannelClosures https://github.com/getAlby/hub/blob/master/lnclient/ldk/ldk.go#L1000

If so, we could check the channel ID to ensure the balance from the same channel is not added twice - this is not right because we can see in the first screenshot, the correct balance is shown in the alert above the channels table.

EDIT: this might be because in the frontend we add the PendingBalancesFromChannelClosures to the TotalOnchainBalanceSats and there is some overlap there. See https://github.com/getAlby/hub/blob/master/frontend/src/screens/channels/Channels.tsx#L310-L312

Needs reproducing first and to address both issues brought up by JP.

[jpl-btc]

If this happens again I'll record it

[rolznz]

This is worse than I thought because if the closing channel TX is not bumped, this could stay showing the wrong amount for many hours