-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump expo version #204
Conversation
Either we need message-port-polyfill or https://github.com/nbd-wtf/nostr-tools/compare/master...rolznz:fix/yield-thread-react-native?expand=1 But this requires us to update the JS SDK to use nostr-tools 2.x first. getAlby/js-sdk#275 and we should update lightning-tools too. |
Update: adding And calling |
…chore/bump-expo-version
Edit: it looks like the crypto webview polyfill is still needed. |
@im-adithya found we don't need the webview crypto polyfill if we remove the crypto subtle dependency in lightning-tools. This should be consumed before merging this PR getAlby/js-lightning-tools#179 |
chore: remove crypto polyfill
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK
Expo Go has released a new version, which requires us to update (at least on iOS).
There seem to be some bugs with the change. For some reason, the webview crypto polyfill seems to not be working (NWC requests do not work)