Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump expo version #204

Merged
merged 8 commits into from
Dec 6, 2024
Merged

chore: bump expo version #204

merged 8 commits into from
Dec 6, 2024

Conversation

rolznz
Copy link
Contributor

@rolznz rolznz commented Nov 28, 2024

Expo Go has released a new version, which requires us to update (at least on iOS).

There seem to be some bugs with the change. For some reason, the webview crypto polyfill seems to not be working (NWC requests do not work)

@rolznz rolznz requested a review from im-adithya November 28, 2024 01:55
@rolznz
Copy link
Contributor Author

rolznz commented Dec 4, 2024

Either we need message-port-polyfill or https://github.com/nbd-wtf/nostr-tools/compare/master...rolznz:fix/yield-thread-react-native?expand=1

But this requires us to update the JS SDK to use nostr-tools 2.x first. getAlby/js-sdk#275 and we should update lightning-tools too.

@rolznz
Copy link
Contributor Author

rolznz commented Dec 4, 2024

Update: adding "message-port-polyfill": "^0.2.0",

And calling import "message-port-polyfill"; from applyGlobalPolyfills is enough. applyGlobalPolyfills might need to be imported before the expo entry point (TBC)

@rolznz
Copy link
Contributor Author

rolznz commented Dec 6, 2024

Edit: it looks like the crypto webview polyfill is still needed.

@rolznz rolznz marked this pull request as ready for review December 6, 2024 08:54
@im-adithya
Copy link
Member

Changed the splash background color to mask the difference

Before and After

@rolznz
Copy link
Contributor Author

rolznz commented Dec 6, 2024

@im-adithya found we don't need the webview crypto polyfill if we remove the crypto subtle dependency in lightning-tools. This should be consumed before merging this PR getAlby/js-lightning-tools#179

Copy link
Member

@im-adithya im-adithya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@im-adithya im-adithya merged commit 3a29c76 into master Dec 6, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants