Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ implement isOnCurve function #51

Merged
merged 1 commit into from
Mar 7, 2024
Merged

Conversation

qd-qd
Copy link
Member

@qd-qd qd-qd commented Mar 7, 2024

This function checks if a point is on the p256r1 curve.

This function checks if a point is on the p256r1 curve.
@qd-qd qd-qd self-assigned this Mar 7, 2024
Copy link

github-actions bot commented Mar 7, 2024

Changes to gas cost

Generated at commit: 5e7cb6c6b3d0ebf4b63e33e70a143e7a398fd769, compared to commit: d6e84c7340b6109ae3de0069892b64108a9c73fc

🧾 Summary (20% most significant diffs)

Contract Method Avg (+/-) %
ImplementationECDSA affAdd +21,612 ❌ +3958.24%
ImplementationCurve pModInv +21,204 ❌ +1111.32%

Full diff report 👇
Contract Deployment Cost (+/-) Method Min (+/-) % Avg (+/-) % Median (+/-) % Max (+/-) % # Calls (+/-)
ImplementationECDSA 630,951 (+87,376) affAdd
zz2Aff
22,147 (+21,612)
23,772 (+21,576)
+4039.63%
+982.51%
22,158 (+21,612)
23,772 (+21,576)
+3958.24%
+982.51%
22,158 (+21,612)
23,772 (+21,576)
+3958.24%
+982.51%
22,170 (+21,612)
23,772 (+21,576)
+3873.12%
+982.51%
2 (0)
1 (0)
ImplementationCurve 146,107 (+59,572) nModInv
pModInv
23,134 (+21,204)
23,112 (+21,204)
+1098.65%
+1111.32%
23,134 (+21,204)
23,112 (+21,204)
+1098.65%
+1111.32%
23,134 (+21,204)
23,112 (+21,204)
+1098.65%
+1111.32%
23,134 (+21,204)
23,112 (+21,204)
+1098.65%
+1111.32%
1 (0)
1 (0)
ImplementationECDSA256r1 1,126,819 (+116,772) mulmuladd
verify
49,889 (+22,356)
192,323 (+23,600)
+81.20%
+13.99%
131,060 (+22,428)
226,387 (+23,571)
+20.65%
+11.62%
130,745 (+22,140)
226,944 (+23,564)
+20.39%
+11.59%
212,862 (+23,076)
254,369 (+23,612)
+12.16%
+10.23%
4 (0)
566 (0)

Copy link

github-actions bot commented Mar 7, 2024

LCOV of commit ca83ad2 during Tests #213

Summary coverage rate:
  lines......: 38.6% (32 of 83 lines)
  functions..: 87.5% (7 of 8 functions)
  branches...: no data found

Files changed coverage rate:
                     |Lines       |Functions  |Branches    
  Filename           |Rate     Num|Rate    Num|Rate     Num
  =========================================================
  src/ECDSA256r1.sol |43.9%     41|66.7%     3|    -      0

@qd-qd qd-qd mentioned this pull request Mar 7, 2024
@qd-qd qd-qd merged commit ca83ad2 into main Mar 7, 2024
7 checks passed
@qd-qd qd-qd deleted the feat/function-is-on-curve branch March 7, 2024 22:21
@qd-qd qd-qd mentioned this pull request Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant