Skip to content

Fix tool calls not being persisted when tools error #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix tool calls not being persisted when tools error #176

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/mapping.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,7 @@ export async function serializeNewMessagesInStep<TOOLS extends ToolSet>(
} satisfies Omit<MessageWithMetadata, "message" | "text" | "fileIds">;
const toolFields = { sources: step.sources };
const messages: MessageWithMetadata[] = await Promise.all(
(step.toolResults.length > 0
(step.finishReason === "tool-calls"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in the case of error, is the finishReason tool-calls?
My understanding of tool-calls finishReason was that it was the signal that there were tool calls that need response, e.g. when you have a tool with no execute function, it will finish with tool-calls but there will only be one response message - the assistant response.

? step.response.messages.slice(-2)
: step.content.length
? step.response.messages.slice(-1)
Expand Down