Repository navigation
Upgrade Electron to 44.3.0 with compatible bundled SQLite - #3659
Merged
SawyerHood merged 3 commits intoSep 14, 2026
Merged
Conversation
SawyerHood
deleted the
bb/upgrade-electron-and-test-functionality-thr_bpa8urbmfs
branch
September 14, 2026 21:33
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Human comments
What was wrong
The desktop shell was pinned to Electron 41.7.0 because the bundled SQLite dependency required Electron-specific native binaries. That SQLite version has no prebuild for Electron 44's ABI, preventing a straightforward upgrade to the latest stable Electron release.
What changed
Upgrade Electron to 44.3.0 and the bundled
bb-appruntime'sbetter-sqlite3to 13.0.3, which ships N-API binaries.Validate packaged SQLite by opening and querying an in-memory database with Electron. Keep the prebuild fallback for older ABI-specific modules and preserve explicit cross-target preparation.
Await asynchronous clipboard writes in the About dialog and return their completion through the log-viewer IPC handler.
Set the macOS minimum to 13.0.0 (Ventura), update desktop documentation, and add a real native SQLite packaging regression test.
Pin the integration test SQLite peer to the server/database version so pnpm resolves one Drizzle instance, and give the native packaging regression a 60-second timeout.
Install Electron runtime libraries on the packages CI runner and verify Electron starts before running tests. Preserve N-API loading errors instead of falling through to an incompatible legacy installer, with a regression check for a corrupt binary.
How you verified
pnpm exec turbo run build typecheck lint --concurrency=4under Node 22 passed: 149 tasks. Desktop tests under Node 22 also passed: 326 tests and one platform-specific skip.pnpm exec turbo run typecheck test --filter=@bb/desktop --filter=bb-app: passed; final desktop suite has 326 passing tests and one platform-specific skip, andbb-apphas 81 passing tests.pnpm exec turbo run package:linux --filter=@bb/desktop: passed, including native SQLite validation and offline plugin dependency installation/update using Electron 44.3.0's bundled Node with an empty PATH.pnpm exec turbo run smoke:packaged --filter=@bb/desktopunder Xvfb: packaged Linux startup/preload bridge passed.pnpm exec turbo run smoke:browser-cdp --filter=@bb/desktopwith Xvfb: all 10 live embedded-browser checks passed, covering navigation, input, screenshots, iframe interaction, thread isolation, reconnection, and automation-tab leases. The fixture completed its checks and cleanup but required forced process termination afterward.git diff --checkpassed.macOS runtime and packaging were not tested on this Linux host.