-
Notifications
You must be signed in to change notification settings - Fork 16
add data source alerting channel office365 #151
add data source alerting channel office365 #151
Conversation
I've prepared a better DRY version of the alert channel code, but will push it tomorrow after I validate it functions properly. If you don't insist on a DRY-er version for now, I'll keep it for a different PR. |
@rumenvasilev I would prefer a DRY-er version. I you don't feel comfortable I would be ok with the change, merge it into a feature branch and cross check options to clean up. |
Here's a more compact version. Tested, still works as before. |
Type: schema.TypeString, | ||
Required: true, | ||
Description: "The name of the alerting channel", | ||
// TODO: What is the max length here? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No restriction defined in the API specification. Would skip also not add any validation in this case.
01228dc
into
gessnerfl:feature/datasource-alert-config-o365
@rumenvasilev thanks a lot for your contribution. I will take it from here and finalize the change on a feature branch |
I would like to add this data source. Implementation-wise I've confirmed it works with terraform code and instana server. Documentation is added too.
Sadly I had to copy the implementation for AlertingChannels to AlertingChannelsDS, due to the fact the former is used as pointer receiver, while we need a value receiver for the read-only interface implementation currently in use for the other data sources.