Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make untestable parts testable non-interactively #69

Open
chainsawriot opened this issue Nov 14, 2022 · 6 comments · Fixed by #83
Open

make untestable parts testable non-interactively #69

chainsawriot opened this issue Nov 14, 2022 · 6 comments · Fixed by #83
Assignees
@chainsawriot
Labels
testability

Comments

@chainsawriot
Copy link
Collaborator

chainsawriot commented Nov 14, 2022 •
edited
Loading

auth_setup's state of being completely untested scares me.
@chainsawriot chainsawriot self-assigned this Nov 14, 2022
@chainsawriot chainsawriot mentioned this issue Nov 15, 2022
Closed
@chainsawriot
Copy link
Collaborator Author

https://github.com/schochastics/rtoot/blob/6cb54be861889de817ba3dae56102b4c70a56f3a/R/auth.R#L32-L42

Spin off this non-interactive part and test this part.

chainsawriot added a commit to chainsawriot/rtoot that referenced this issue Nov 15, 2022
@chainsawriot
use parameter verbose; spin off non-interactive parts in auth_setup
b262b9e 
gesistsa#69
schochastics added a commit that referenced this issue Nov 15, 2022
@schochastics
Merge pull request #74 from chainsawriot/auth_test
cc66788 
use parameter `verbose`; spin off non-interactive parts in `auth_setup` #69
@chainsawriot chainsawriot changed the title make auth_setup testable non-interactively make untestable parts testable non-interactively Nov 16, 2022
@chainsawriot
Copy link
Collaborator Author

chainsawriot commented Nov 16, 2022 •
edited
Loading

  • auth_setup - 60% done
    • check_token_rtoot
  • process_query's rate limit
    • wait_until
    • rate_limit_remaining

This was referenced Nov 17, 2022
Closed
Merged
@chainsawriot chainsawriot reopened this Nov 17, 2022
This was referenced Nov 18, 2022
Merged
Closed
@chainsawriot
Copy link
Collaborator Author

chainsawriot commented Nov 28, 2022 •
edited
Loading

  • This logic

https://github.com/schochastics/rtoot/blob/5821642244d09dbb755bd6557eed7cdccb15be4f/R/utils.R#L100-L109

@chainsawriot
Copy link
Collaborator Author

  • Breakdown create_token into units

@chainsawriot
Copy link
Collaborator Author

chainsawriot commented Nov 28, 2022 •
edited
Loading

  • verify_credentials for public tokens

@chainsawriot
Copy link
Collaborator Author

chainsawriot commented Nov 28, 2022 •
edited
Loading

  • auth_setup verbose

chainsawriot added a commit to chainsawriot/rtoot that referenced this issue Dec 22, 2022
@chainsawriot
refactor rate limit checking code in process_request, ref gesistsa#69
50420ed 
* Testable + unit tests
* Reduce cyclomatic complexity
* Using semantic variable name (`api_response` vs `tmp`)
schochastics added a commit that referenced this issue Dec 22, 2022
@schochastics
Merge pull request #127 from chainsawriot/process
b1ca4d5 
refactor rate limit checking code in `process_request`, ref #69
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chainsawriot chainsawriot

Labels
testability
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix #82 chainsawriot/rtoot
1 participant
@chainsawriot