Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add configs and secrets support for stacks/services #82

Merged
merged 4 commits into from
Mar 17, 2019

Conversation

gesellix
Copy link
Owner

@ralmn
Copy link

ralmn commented Mar 17, 2019

Can you add in same time the templating params on createConfig ?

https://docs.docker.com/engine/api/v1.39/#operation/ConfigCreate

@gesellix
Copy link
Owner Author

@ralmn I'll have a look into it, most probably yes 👍

@gesellix
Copy link
Owner Author

@ralmn I've added both driver and templating in secrets and configs. As far as I've seen there's no support for templating in Compose/Stack YAML, do you agree?

@gesellix gesellix merged commit 337eb3e into master Mar 17, 2019
@gesellix gesellix deleted the stack-configs-and-secrets branch March 17, 2019 20:20
@gesellix
Copy link
Owner Author

Available as of release 2019-03-17T20-30-50.

@ralmn
Copy link

ralmn commented Mar 17, 2019

Thank you for the templating. I don't have seen this in compose spec. I think too isn't supporting. But for my project we will create config in external (for reuse them in many stack).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for secrets in DeployConfigReader
2 participants